Skip to content

Commit

Permalink
remove mutation_errors and update dashboard (#17195)
Browse files Browse the repository at this point in the history
  • Loading branch information
@adel121
adel121 authored Mar 15, 2024
1 parent 65aa58e commit 09364fe
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 62 deletions.
57 changes: 2 additions & 55 deletions datadog_cluster_agent/assets/dashboards/datadog_cluster_agent_overview.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1393,7 +1393,7 @@
{
"data_source": "metrics",
"name": "query1",
"query": "avg:datadog.cluster_agent.admission_webhooks.mutation_attempts{injected:true,$cluster,$namespace} by {mutation_type}"
"query": "avg:datadog.cluster_agent.admission_webhooks.mutation_attempts{status:success,$cluster,$namespace} by {mutation_type, injected}"
}
],
"response_format": "timeseries",
Expand All @@ -1420,59 +1420,6 @@
"height": 2
}
},
{
"id": 4551516642114976,
"definition": {
"title": "Mutation errors by type and reason",
"show_legend": true,
"legend_layout": "auto",
"legend_columns": [
"avg",
"min",
"max",
"value",
"sum"
],
"type": "timeseries",
"requests": [
{
"formulas": [
{
"formula": "query1"
}
],
"on_right_yaxis": false,
"queries": [
{
"data_source": "metrics",
"name": "query1",
"query": "avg:datadog.cluster_agent.admission_webhooks.mutation_errors{$cluster,$namespace} by {mutation_type,reason}"
}
],
"response_format": "timeseries",
"style": {
"palette": "dog_classic",
"line_type": "solid",
"line_width": "normal"
},
"display_type": "area"
}
],
"yaxis": {
"include_zero": true,
"scale": "linear",
"min": "auto",
"max": "auto"
},
"markers": []
},
"layout": {
"x": 8,
"y": 16,
"width": 4,
"height": 2
}
},
{
"id": 1453748622802082,
"definition": {
Expand Down Expand Up @@ -1583,7 +1530,7 @@
{
"data_source": "metrics",
"name": "query1",
"query": "avg:datadog.cluster_agent.admission_webhooks.mutation_attempts{injected:false,$cluster,$namespace} by {mutation_type}"
"query": "avg:datadog.cluster_agent.admission_webhooks.mutation_attempts{status:error,$cluster,$namespace} by {mutation_type}"
}
],
"response_format": "timeseries",
Expand Down
1 change: 1 addition & 0 deletions datadog_cluster_agent/changelog.d/17195.removed
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
removed `admission_webhooks.mutation_errors` metric in the `datadog_cluster_agent` integration
1 change: 0 additions & 1 deletion datadog_cluster_agent/datadog_checks/datadog_cluster_agent/check.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
'admission_webhooks_library_injection_attempts': 'admission_webhooks.library_injection_attempts',
'admission_webhooks_library_injection_errors': 'admission_webhooks.library_injection_errors',
'admission_webhooks_mutation_attempts': 'admission_webhooks.mutation_attempts',
'admission_webhooks_mutation_errors': 'admission_webhooks.mutation_errors',
'admission_webhooks_patcher_attempts': 'admission_webhooks.patcher.attempts',
'admission_webhooks_patcher_completed': 'admission_webhooks.patcher.completed',
'admission_webhooks_patcher_errors': 'admission_webhooks.patcher.errors',
Expand Down
14 changes: 9 additions & 5 deletions datadog_cluster_agent/tests/fixtures/metrics.txt
View file
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
# HELP admission_webhooks_certificate_expiry Time left before the certificate expires in hours.
# TYPE admission_webhooks_certificate_expiry gauge
admission_webhooks_certificate_expiry 11.083180892013889
# HELP admission_webhooks_mutation_attempts Number of pod mutation attempts by mutation type (agent config, standard tags).
# HELP admission_webhooks_mutation_attempts Number of pod mutation attempts by mutation type
# TYPE admission_webhooks_mutation_attempts gauge
admission_webhooks_mutation_attempts{mutation_type="agent_config"} 100
# HELP admission_webhooks_mutation_errors Number of mutation failures by mutation type (agent config, standard tags).
# TYPE admission_webhooks_mutation_errors gauge
admission_webhooks_mutation_errors{mutation_type="agent_config"} 1
admission_webhooks_mutation_attempts{error="",injected="false",mutation_type="agent_sidecar",status="success"} 1
admission_webhooks_mutation_attempts{error="",injected="false",mutation_type="cws_exec_instrumentation",status="success"} 1
admission_webhooks_mutation_attempts{error="",injected="false",mutation_type="lib_injection",status="success"} 1
admission_webhooks_mutation_attempts{error="",injected="false",mutation_type="standard_tags",status="success"} 2
admission_webhooks_mutation_attempts{error="",injected="true",mutation_type="agent_config",status="success"} 2
admission_webhooks_mutation_attempts{error="",injected="true",mutation_type="agent_sidecar",status="success"} 1
admission_webhooks_mutation_attempts{error="",injected="true",mutation_type="cws_pod_instrumentation",status="success"} 2
admission_webhooks_mutation_attempts{error="",injected="true",mutation_type="lib_injection",status="success"} 1
# HELP admission_webhooks_reconcile_errors Number of reconcile errors per controller.
# TYPE admission_webhooks_reconcile_errors gauge
admission_webhooks_reconcile_errors{controller="secrets"} 5
Expand Down
1 change: 0 additions & 1 deletion datadog_cluster_agent/tests/test_datadog_cluster_agent.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
'admission_webhooks.library_injection_attempts',
'admission_webhooks.library_injection_errors',
'admission_webhooks.mutation_attempts',
'admission_webhooks.mutation_errors',
'admission_webhooks.patcher.attempts',
'admission_webhooks.patcher.completed',
'admission_webhooks.patcher.errors',
Expand Down

0 comments on commit 09364fe

Please sign in to comment.