Enhance exception handling when a Semgrep rule fails to run (#69)

DataDog · Nov 22, 2022 · a4a3d9e · a4a3d9e
1 parent 44a32b4
commit a4a3d9e
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/guarddog/analyzer/analyzer.py b/guarddog/analyzer/analyzer.py
@@ -132,7 +132,7 @@ def analyze_metadata(self, info, rules=None) -> dict[str]:
                     issues += 1
                     results[rule] = message
             except Exception as e:
-                errors[rule] = str(e)
+                errors[rule] = f"failed to run rule {rule}: {str(e)}"
 
         return {"results": results, "errors": errors, "issues": issues}
 
@@ -156,11 +156,14 @@ def analyze_sourcecode(self, path, rules=None) -> tuple[dict, int]:
 
         if rules is None:
             # No rule specified, run all rules
-            response = invoke_semgrep(Path(self.sourcecode_path), [targetpath], exclude=self.exclude, no_git_ignore=True)
-            rule_results = self._format_semgrep_response(response, targetpath=targetpath)
-            issues += len(rule_results)
-
-            results = results | rule_results
+            try:
+                response = invoke_semgrep(Path(self.sourcecode_path), [targetpath], exclude=self.exclude, no_git_ignore=True)
+                rule_results = self._format_semgrep_response(response, targetpath=targetpath)
+                issues += len(rule_results)
+
+                results = results | rule_results
+            except Exception as e:
+                errors["rules-all"] = f"failed to run rule: {str(e)}"
         else:
             for rule in rules:
                 try:
@@ -175,7 +178,7 @@ def analyze_sourcecode(self, path, rules=None) -> tuple[dict, int]:
 
                     results = results | rule_results
                 except Exception as e:
-                    errors[rule] = str(e)
+                    errors[rule] = f"failed to run rule {rule}: {str(e)}"
 
         return {"results": results, "errors": errors, "issues": issues}