[web-6210] supporting APW integrations #29759
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
bgdeutsch
commented
Jun 5, 2025
| @@ -147,9 +147,6 @@ config: | |||
|
|
|||
| # Automatically download the latest module from websites-sources repo | |||
| update_websites_sources_module: | |||
| node_modules/hugo-bin/vendor/hugo mod get github.com/DataDog/websites-sources@main | |||
There was a problem hiding this comment.
need to revert this before merging
Comment on lines
+3
to
+14
| github.com/DataDog/websites-sources v0.0.0-20250527204404-64c5172a7084 h1:fm2rtCZTy4mwDDPAZpQqIeYCQDZQ4w7iazQzhbBNEsU= | ||
| github.com/DataDog/websites-sources v0.0.0-20250527204404-64c5172a7084/go.mod h1:RvGhXV0uQC6Ocs+n84QyL97kows6vg6VG5ZLQMHw4Fs= | ||
| github.com/DataDog/websites-sources v0.0.0-20250530164735-428a343bc531 h1:eKj7k+/ZqsjMka7p3z/C9XaZtbucO85tWYB/ln/ZiqY= | ||
| github.com/DataDog/websites-sources v0.0.0-20250530164735-428a343bc531/go.mod h1:RvGhXV0uQC6Ocs+n84QyL97kows6vg6VG5ZLQMHw4Fs= | ||
| github.com/DataDog/websites-sources v0.0.0-20250530181203-97d3892e641b h1:t4WXtleM8JBJmjxuzEzKbOncaCSSF+LAcPuPaNQtICU= | ||
| github.com/DataDog/websites-sources v0.0.0-20250530181203-97d3892e641b/go.mod h1:RvGhXV0uQC6Ocs+n84QyL97kows6vg6VG5ZLQMHw4Fs= | ||
| github.com/DataDog/websites-sources v0.0.0-20250602200419-0e42ce935433 h1:Fsx7WwwTL3pd9Z0/M3WZXXoPH2JWms1HJpuX6K35xYk= | ||
| github.com/DataDog/websites-sources v0.0.0-20250602200419-0e42ce935433/go.mod h1:RvGhXV0uQC6Ocs+n84QyL97kows6vg6VG5ZLQMHw4Fs= | ||
| github.com/DataDog/websites-sources v0.0.0-20250603203822-19b49b3d8e35 h1:SheinDQaM2OLxEdCUNchvTVdEHp4FcvbShY3PjTs3Xc= | ||
| github.com/DataDog/websites-sources v0.0.0-20250603203822-19b49b3d8e35/go.mod h1:RvGhXV0uQC6Ocs+n84QyL97kows6vg6VG5ZLQMHw4Fs= | ||
| github.com/DataDog/websites-sources v0.0.0-20250604232349-f7ff10a194f0 h1:0DyMTgo7aNCfnC6AzIAF6mr34xMBPOCG9yJY7AucEeo= | ||
| github.com/DataDog/websites-sources v0.0.0-20250604232349-f7ff10a194f0/go.mod h1:RvGhXV0uQC6Ocs+n84QyL97kows6vg6VG5ZLQMHw4Fs= |
There was a problem hiding this comment.
@bgdeutsch there are many websites-sources refs here. is this expected?
go.mod
Outdated
| @@ -4,7 +4,7 @@ go 1.14 | |||
|
|
|||
| require ( | |||
| github.com/DataDog/websites-modules v1.4.229 // indirect | |||
| github.com/DataDog/websites-sources v0.0.0-20250416175658-6e7c09b9db13 // indirect | |||
| github.com/DataDog/websites-sources v0.0.0-20250604232349-f7ff10a194f0 // indirect | |||
There was a problem hiding this comment.
@bgdeutsch hello! how were you able to generate a websites-sources preview reference?
| # - "*/assets/service_checks.json" | ||
| # - "*/assets/metrics/metric-spec.yaml" | ||
| # - "*/README.md" | ||
| # - "*/datadog_checks/*/__about__.py" |
There was a problem hiding this comment.
do we need to do the same thing for the pull_config?
Signed-off-by: Brian Deutsch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Sourcing integrations through APW: https://github.com/DataDog/websites-sources/pull/305
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes
Use the sources PR for testing instructions if needed