Skip to content

[RUM] React Native - Update setUser method to setUserInfo #28949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jhssilva
Copy link
Contributor

@jhssilva jhssilva commented Apr 24, 2025

What does this PR do? What is the motivation?

This update reflects a change introduced in version 2.6.5 of the React Native SDK. The method previously used for setting user information—setUser—has been renamed to setUserInfo. This PR updates the documentation accordingly to ensure consistency with the current SDK API.

PR introducing the change

image

Merge instructions

  • Please confirm that passing an empty object to setUserInfo is the recommended way to clear user data upon logout.
    Note: It was clarified that the correct way to clear the user object it's by using setUser by @sbarrio on the review comment.

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@jhssilva jhssilva changed the title [RUM] Update setUser method to setUserInfo [RUM] React Native - Update setUser method to setUserInfo Apr 24, 2025
Copy link
Contributor

@jhssilva jhssilva marked this pull request as ready for review April 24, 2025 09:23
@jhssilva jhssilva requested a review from a team as a code owner April 24, 2025 09:23
@marco-saia-datadog marco-saia-datadog self-requested a review April 24, 2025 09:34
Copy link
Member

@marco-saia-datadog marco-saia-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 🙌

Copy link
Contributor

@sbarrio sbarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again 🙇

Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@cswatt
Copy link
Contributor

cswatt commented Apr 24, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 24, 2025

View all feedbacks in Devflow UI.

2025-04-24 15:29:01 UTC ℹ️ Start processing command /merge


2025-04-24 15:29:14 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 19m (p90).


2025-04-24 15:50:16 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 6ff67ab into master Apr 24, 2025
20 of 22 checks passed
@dd-mergequeue dd-mergequeue bot deleted the hugo.silva/teep-655-rum-react-native-setUserInfo branch April 24, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants