Skip to content

[DJM-218] Remove install logs section in Databricks page #28948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aboitreaud
Copy link
Contributor

@aboitreaud aboitreaud commented Apr 24, 2025

What does this PR do? What is the motivation?

Remove the paragraph about the send install logs to datadog and install log file /tmp/datadog-djm-init.log. This file is no longer used as out new scripts are collecting all the telemetry we need to debug customers cases. This guideline is now misleading.

Also some copy updated on

  • the databricks token expiration as it feels strange now that tokens do expire.
  • token identity so we use Databricks official wording on token Principal

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@aboitreaud aboitreaud marked this pull request as ready for review April 24, 2025 08:51
@aboitreaud aboitreaud requested a review from a team as a code owner April 24, 2025 08:51
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@aboitreaud aboitreaud changed the title [DJMM] Remove install logs section in Databricks page [DJM] Remove install logs section in Databricks page Apr 24, 2025
Copy link
Contributor

@warrierr warrierr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aboitreaud aboitreaud changed the title [DJM] Remove install logs section in Databricks page [DJM-218] Remove install logs section in Databricks page Apr 24, 2025
@domalessi domalessi self-assigned this Apr 24, 2025
Copy link
Contributor

@domalessi domalessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks; otherwise, looks good! Hit me up when you've reviewed and need a final check/approval.

@aboitreaud
Copy link
Contributor Author

Thanks a lot for the suggestions, I applied them. We are ready to merge !

@aboitreaud
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 24, 2025

View all feedbacks in Devflow UI.

2025-04-24 16:30:11 UTC ℹ️ Start processing command /merge


2025-04-24 16:30:20 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-04-24 17:08:19 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 19m (p90).


2025-04-24 17:28:20 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 2814719 into master Apr 24, 2025
14 of 18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the adrien.boitreaud/update-troubleshooting-guidelines branch April 24, 2025 17:28
lkretvix added a commit that referenced this pull request Apr 25, 2025
…kretvix/dsm-add-new-technology-pages

* 'master' of github.com:DataDog/documentation: (33 commits)
  Update databricks.md (#28979)
  [SCA] Change Repo Settings Link in SCA Setup + Troubleshooting page (#28975)
  add recommendation for RabbitMQ integration (#28945)
  add warning for openai byok (#28813)
  SDCD-1160: specifying dora change lead time limitation if previous deployment was too far in the past (#28956)
  Add helm to argocd docs (#28630)
  added that TCP is not available for gov site (#28972)
  Translation Pipeline PR (#28965)
  Update explorer.md (#28970)
  [DOCS-10642] Add Snowflake section to OP Amazon S3 destination (#28967)
  remove "preview" callout from datastore docs (#28963)
  Update check_references.md (#28855)
  Update Private Location Windows version to 1.56.1 (#28950)
  Improve Cdocs logging to catch environment issues (#28961)
  [DOCS-10446] changes to Resource Catalog policies (#28389)
  Add code snippet for Kotlin Multiplatform (#28954)
  minor rum edits (#28106)
  [DOCS-10699] add regions to restricted networks page (#28958)
  [DJM-218] Remove install logs section in Databricks page (#28948)
  [Debugger] Bump minimum Node.js tracer version (#28957)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants