Skip to content

Teddy.gesbert/doc dora #28914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Teddy.gesbert/doc dora #28914

wants to merge 31 commits into from

Conversation

Tecoddy
Copy link
Contributor

@Tecoddy Tecoddy commented Apr 22, 2025

What does this PR do? What is the motivation?

Added documentation for backfilling historical data when using Incident Management as a DORA failure source.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

Tecoddy and others added 24 commits March 17, 2025 18:43
Change deployment.merge_time to Merge Time (i.e. metric to field) to avoid any confusion with previous Metrics type
- Added consistency between data sources requirements.
- Remove /dora_metrics/failures/datadog_incidents alias as not needed.
Added backfill documentation for retrieving past incidents using Incident Management as a DORA failure source.
@Tecoddy Tecoddy requested review from a team as code owners April 22, 2025 17:52
@Tecoddy Tecoddy requested a review from henrywalsh April 22, 2025 17:52
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small suggestions! Also, could you fix the merge conflict?

Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@Tecoddy
Copy link
Contributor Author

Tecoddy commented Apr 23, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 23, 2025

View all feedbacks in Devflow UI.

2025-04-23 09:02:32 UTC ℹ️ Start processing command /merge


2025-04-23 09:02:39 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-04-23 10:06:12 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 18m (p90).


2025-04-23 10:06:27 UTCMergeQueue: This merge request was updated

This PR is rejected because it was updated

@Tecoddy Tecoddy requested a review from calvarjorge April 23, 2025 16:55
@buraizu buraizu requested a review from maycmlee April 23, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants