Skip to content

[profiling] Add beta outgoing HTTP request profiling to .NET #28806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025

Conversation

chrisnas
Copy link
Contributor

What does this PR do? What is the motivation?

Add outgoing HTTP request profiling in .NET profiling documentation

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@chrisnas chrisnas requested a review from a team as a code owner April 16, 2025 09:51
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion, not blocking so approved!

@@ -66,7 +66,7 @@ The following profiling features are available in the following minimum versions
| Live heap profiling beta | 2.22.0+ | .NET 7+ |
| [Trace to Profiling integration][12] | 2.30.0+ | All supported runtime versions. |
| [Endpoint Profiling][13] | 2.15.0+ | All supported runtime versions. |
| Timeline | 2.30.0+ | All supported runtime versions (except .NET 5+ required for garbage collection details). |
| Timeline | 2.30.0+ (and 3.10.0+ for outgoing HTTP requests longer than 50 ms in beta) | All supported runtime versions (except .NET 5+ required for garbage collection details and .NET 7+ required for outgoing HTTP requests). |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Timeline | 2.30.0+ (and 3.10.0+ for outgoing HTTP requests longer than 50 ms in beta) | All supported runtime versions (except .NET 5+ required for garbage collection details and .NET 7+ required for outgoing HTTP requests). |
| Timeline | 2.30.0+ (and 3.10.0+ for outgoing HTTP requests longer than 50 ms in Preview) | All supported runtime versions (except .NET 5+ required for garbage collection details and .NET 7+ required for outgoing HTTP requests). |

Small update per Product lifecycle changes, however, ok to leave if your team has elected to keep "beta" wording for the libraries. (I see its used in other places on the page).

@aliciascott
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 16, 2025

View all feedbacks in Devflow UI.

2025-04-16 14:57:00 UTC ℹ️ Start processing command /merge


2025-04-16 14:57:19 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 18m (p90).


2025-04-16 15:11:31 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 2379fed into master Apr 16, 2025
16 of 18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the chrisnas/add_http_profiling branch April 16, 2025 15:11
estherk15 pushed a commit that referenced this pull request Apr 17, 2025
* Add beta outgoing HTTP request profiling to .NET

* Fix table layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants