fix: wrap predicates in curly braces to correct syntax #27323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylfin
force-pushed
the
tyler.finethy/di-exp-lang-fix-example-syntax
branch
from
ebc6207 to
d5a28df
Compare
Preview links (active after the
|
1 task
jhgilbert
approved these changes
Jan 27, 2025
|
Hi @tylfin, I didn't merge this since there's another requested reviewer on it. But once you get the additional approval, you can merge the PR by commenting |
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
bot
deleted the
tyler.finethy/di-exp-lang-fix-example-syntax
branch
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
This pull request includes a small but important change to the
content/en/dynamic_instrumentation/expression-language.mdfile. The change corrects the syntax for predicates in examples to use curly braces{}properly.content/en/dynamic_instrumentation/expression-language.md: Corrected the predicate syntax in the examples forany,all, andfilterfunctions to use curly braces{}.Manually tested the
any,all, andfiltermethods against a dogfood environment with the correct syntax (Java app).Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes