Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLOB-2083] Add Azure OpenAI Configuration Section for Evaluations #27289

Merged

Conversation

davit-bar
Copy link
Contributor

@davit-bar davit-bar commented Jan 24, 2025

What does this PR do? What is the motivation?

This PR adds instructions for azure openai integration to existing openai integration.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@davit-bar davit-bar self-assigned this Jan 24, 2025
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@github-actions github-actions bot added the Images Images are added/removed with this PR label Jan 27, 2025
@davit-bar davit-bar marked this pull request as ready for review January 27, 2025 18:46
@davit-bar davit-bar requested a review from a team as a code owner January 27, 2025 18:46
@davit-bar davit-bar requested a review from a team January 27, 2025 18:46
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davit-bar - Thanks for this update! Looks good other than two requests:

  • Link 2 is broken in both of the tabs. It needs to be moved inside the tab from the bottom of the page.
  • openai-tile-2.png needs to be added back. Removing images straight away breaks images on our translated pages.

Thank you!

content/en/llm_observability/configuration/_index.md Outdated Show resolved Hide resolved
content/en/llm_observability/configuration/_index.md Outdated Show resolved Hide resolved
@davit-bar davit-bar removed the request for review from a team January 28, 2025 17:39
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good--thanks!!

@davit-bar davit-bar requested a review from barieom January 28, 2025 17:50
@davit-bar
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 28, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-28 22:13:01 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-01-28 22:20:11 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit fef5201 into master Jan 28, 2025
16 of 17 checks passed
@dd-mergequeue dd-mergequeue bot deleted the davit.b/MLOB-2083-update-documentation-for-azure-openai branch January 28, 2025 22:20
buraizu pushed a commit that referenced this pull request Jan 29, 2025
…27289)

* update documentation for azure openai

* update documentation for azure openai

* update documentation for azure openai

* add image

* add image

* nit

* update images

* nit

* nit

* fix urls

* remove old screenshots

* add deleted image back

* Update content/en/llm_observability/configuration/_index.md

Co-authored-by: Brett Blue <[email protected]>

* Update content/en/llm_observability/configuration/_index.md

Co-authored-by: Brett Blue <[email protected]>

* update url ordering

* add disclaimer for the model option

* update screenshot

* update text

---------

Co-authored-by: Brett Blue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants