Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a View PCI Status Section #27287

Merged
merged 12 commits into from
Jan 27, 2025
Merged

Added a View PCI Status Section #27287

merged 12 commits into from
Jan 27, 2025

Conversation

helen-zxb
Copy link
Contributor

@helen-zxb helen-zxb commented Jan 24, 2025 •
edited
Loading

What does this PR do? What is the motivation?

Adds information on how to view PCI Status in Datadog ahead of the upcoming rollout to show PCI Status inside Safety Center.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@helen-zxb helen-zxb marked this pull request as ready for review January 24, 2025 18:56
@helen-zxb helen-zxb requested a review from a team as a code owner January 24, 2025 18:56
@github-actions github-actions bot added the Images Images are added/removed with this PR label Jan 24, 2025
@helen-zxb helen-zxb requested a review from neko-dd January 24, 2025 20:01
@github-actions github-actions bot removed the Images Images are added/removed with this PR label Jan 24, 2025
@github-actions github-actions bot added the Images Images are added/removed with this PR label Jan 24, 2025
@helen-zxb @neko-dd
change image file paths
b6ba82f 
Co-authored-by: Sandra (neko) <[email protected]>
@jinatdatadog
Copy link
Contributor

thanks Helen!! Just a small nit:

  • Can we change the header to "View your PCI compliance status"?

@helen-zxb @neko-dd
Use sentence casing for header
2cf975a 
Co-authored-by: Sandra (neko) <[email protected]>
@helen-zxb
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 27, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-01-27 18:48:20 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-01-27 19:03:11 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.

2025-01-27 19:11:01 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 3d25036 into master Jan 27, 2025
19 of 22 checks passed
@dd-mergequeue dd-mergequeue bot deleted the helen.zhu/add-safety-center-to-pci-documentation branch January 27, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neko-dd neko-dd neko-dd approved these changes

Assignees
No one assigned
Labels
Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helen-zxb @jinatdatadog @neko-dd