Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs9894/add new facets #27268

Merged
merged 26 commits into from
Jan 29, 2025
Merged

Docs9894/add new facets #27268

merged 26 commits into from
Jan 29, 2025
+36 −40

Conversation

buraizu
Copy link
Contributor

@buraizu buraizu commented Jan 24, 2025 •
edited
Loading

What does this PR do? What is the motivation?

  • Add new information about the Query Activity facet
  • Update related images
  • Correct minor style issues flagged by the Vale linter

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@buraizu buraizu added the WORK IN PROGRESS No review needed, it's a wip ;) label Jan 24, 2025
@buraizu buraizu requested a review from a team as a code owner January 24, 2025 00:12
@github-actions github-actions bot added the Images Images are added/removed with this PR label Jan 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited
Loading

Preview links (active after the build_preview check completes)

Modified Files

@github-actions github-actions bot added the Guide Content impacting a guide label Jan 24, 2025
@buraizu buraizu requested a review from ijkaylin January 24, 2025 16:46
@buraizu buraizu removed the WORK IN PROGRESS No review needed, it's a wip ;) label Jan 29, 2025
@buraizu buraizu removed the request for review from ijkaylin January 29, 2025 18:19
janine-c
janine-c reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I noticed some names in the screenshots that we might want to blur out, but everything else looks ready to go 🙂

content/en/metrics/guide/custom_metrics_governance.md Outdated Show resolved Hide resolved
static/images/metrics/summary/facet_panel.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did notice that we have Andrews.silly.metric in here, but I'm not sure if that rises to the level of needing to be blurred out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging that; this image is from the demo account so the metric data is safe for sharing.

static/images/metrics/volume/id_unqueried_metrics_2025-01-23.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whose names these are or if they're real people, but I think we should probably blur those out just to be on the safe side?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging that; I've blurred out the names in f7653b9. With that said, this image is from the demo account and should be safe for sharing.

static/images/metrics/volume/related_assets_2025-01-23.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blur out the names here too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is very similar to the related_assets_2025-01-27.png file - just want to double check if they should be separate files, or if you can use the other image where this one is referenced, to save you a bit of image editing work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that; I've moved the more recent image in c25fb14, updated its location in the two files that reference it in a227aef, and deleted the old image in ca354e1.

@buraizu buraizu requested a review from janine-c January 29, 2025 20:21
janine-c
janine-c approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastico!

@ijkaylin
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 29, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-01-29 21:43:52 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-01-29 21:48:13 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.

2025-01-29 21:54:00 UTC ℹ️ MergeQueue: This merge request was merged

@ijkaylin
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 29, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-01-29 21:44:02 UTC ❌ MergeQueue

PR already in the queue with status waiting

@dd-mergequeue dd-mergequeue bot merged commit a9b02fd into master Jan 29, 2025
17 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the docs9894/add-new-facets branch January 29, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janine-c janine-c janine-c approved these changes

@ijkaylin ijkaylin ijkaylin approved these changes

Assignees
No one assigned
Labels
Guide Content impacting a guide Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buraizu @ijkaylin @janine-c