Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add files via upload #27223

Merged
merged 38 commits into from
Feb 3, 2025
Merged

Add files via upload #27223

merged 38 commits into from
Feb 3, 2025

Conversation

khangtruong
Copy link
Contributor

What does this PR do? What is the motivation?

This PR adds a new guide on Monitors, around Notifications.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

@khangtruong khangtruong requested a review from a team as a code owner January 22, 2025 10:35
@github-actions github-actions bot added the Guide Content impacting a guide label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited
Loading

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

@estherk15 estherk15 added the editorial review Waiting on a more in-depth review label Jan 22, 2025
@estherk15
Copy link
Contributor

Editorial Review card: https://datadoghq.atlassian.net/browse/DOCS-9913

@github-actions github-actions bot added the Images Images are added/removed with this PR label Jan 22, 2025
estherk15
estherk15 reviewed Jan 24, 2025
View reviewed changes
content/en/monitors/guide/notification-message-best-practices.md Outdated Show resolved Hide resolved
content/en/monitors/guide/notification-message-best-practices.md Outdated Show resolved Hide resolved
content/en/monitors/guide/notification-message-best-practices.md Outdated Show resolved Hide resolved
content/en/monitors/guide/notification-message-best-practices.md Outdated Show resolved Hide resolved
content/en/monitors/guide/notification-message-best-practices.md Outdated Show resolved Hide resolved
content/en/monitors/guide/notification-message-best-practices.md Outdated Show resolved Hide resolved
content/en/monitors/guide/notification-message-best-practices.md Outdated Show resolved Hide resolved
content/en/monitors/guide/notification-message-best-practices.md Outdated Show resolved Hide resolved
content/en/monitors/guide/notification-message-best-practices.md Outdated Show resolved Hide resolved
content/en/monitors/guide/notification-message-best-practices.md Outdated Show resolved Hide resolved
khangtruong and others added 19 commits January 27, 2025 10:52
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
f17e781 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
9c9cb00 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
a5d9108 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
0b3e5dc 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
a55ccd1 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
281f603 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
bc4c14c 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
8315168 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
99b760c 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
3dc89ce 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong
Merge branch 'master' into khang.truong/add_notification_guide
ab3fffc
@estherk15
Formatting the headers and fix guide index typo
9266d38
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
80d3998 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
e2ec830 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
65d8eb5 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
8c91918 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
df1acd1 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
3c8480f 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
e3f95d2 
Co-authored-by: Esther Kim <[email protected]>
khangtruong and others added 14 commits January 28, 2025 10:59
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
98c216f 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
8f05c29 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
5765358 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
f9dddec 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
ac914a8 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
29ec8f9 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
3e2fd89 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
5645100 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
9c952e4 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
8854187 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
5df704e 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
0a74a5f 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong @estherk15
Update content/en/monitors/guide/notification-message-best-practices.md
341feeb 
Co-authored-by: Esther Kim <[email protected]>
@khangtruong
Merge branch 'master' into khang.truong/add_notification_guide
87a6bc8
@estherk15
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 3, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-02-03 19:19:46 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-02-03 19:38:19 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.

2025-02-03 19:45:10 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit c03fd2a into master Feb 3, 2025
18 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the khang.truong/add_notification_guide branch February 3, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherk15 estherk15 estherk15 approved these changes

Assignees
No one assigned
Labels
editorial review Waiting on a more in-depth review Guide Content impacting a guide Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khangtruong @estherk15