Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Better documentation for notification preferences for On-Call #26907

Merged
merged 15 commits into from
Jan 14, 2025

Conversation

Dalje-et
Copy link
Contributor

@Dalje-et Dalje-et commented Dec 26, 2024

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@github-actions github-actions bot added the Images Images are added/removed with this PR label Dec 26, 2024
@Dalje-et Dalje-et changed the title Better documentation for notification preferences for On-Call [Draft] Better documentation for notification preferences for On-Call Dec 26, 2024
@Dalje-et Dalje-et marked this pull request as ready for review December 26, 2024 22:15
@Dalje-et Dalje-et requested a review from a team as a code owner December 26, 2024 22:15
@Dalje-et
Copy link
Contributor Author

moved this from Draft PR to normal PR to see if that prohibited the CI to create a preview. The PR is still a draft

@aliciascott
Copy link
Contributor

moved this from Draft PR to normal PR to see if that prohibited the CI to create a preview. The PR is still a draft

Hi @Dalje-et
Looks like it's breaking from this line // TO DO

@Dalje-et
Copy link
Contributor Author

Huh, interesting. Thanks Alicia!

@estherk15 estherk15 added the WORK IN PROGRESS No review needed, it's a wip ;) label Dec 27, 2024
@Dalje-et Dalje-et marked this pull request as draft December 27, 2024 15:04
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jan 2, 2025
@Dalje-et Dalje-et removed the WORK IN PROGRESS No review needed, it's a wip ;) label Jan 2, 2025
@Dalje-et Dalje-et marked this pull request as ready for review January 2, 2025 21:09
@cswatt
Copy link
Contributor

cswatt commented Jan 2, 2025

added DOCS-9808 to review

@cswatt cswatt added the editorial review Waiting on a more in-depth review label Jan 2, 2025
@Dalje-et
Copy link
Contributor Author

Dalje-et commented Jan 13, 2025

Hey @cswatt, any update on this? I would love to get this out this week :)

@cswatt
Copy link
Contributor

cswatt commented Jan 14, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 14, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-14 23:50:50 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-01-14 23:56:34 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 3684a79 into master Jan 14, 2025
17 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the daljeet/onboard-to-mobile-app branch January 14, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants