Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test optimization] [SDTEST-996] Add instructions for test session name #26807

Merged
merged 6 commits into from
Jan 24, 2025
Merged

[test optimization] [SDTEST-996] Add instructions for test session name #26807

merged 6 commits into from
Jan 24, 2025

Conversation

juan-fernandez
Copy link
Contributor

@juan-fernandez juan-fernandez commented Dec 17, 2024 •
edited
Loading

What does this PR do? What is the motivation?

Let users know about test session name and how they can use it.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

https://docs-staging.datadoghq.com/juan-fernandez/test-session-name-SDTEST-996/tests/setup/javascript/?tab=ciproviderwithautoinstrumentationsupport#dd_test_session_name

@juan-fernandez juan-fernandez changed the title [test optimization] Add instructions for test session name [test optimization] [SDTEST-996] Add instructions for test session name Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Preview links (active after the build_preview check completes)

Modified Files

@juan-fernandez juan-fernandez added the Do Not Merge Just do not merge this PR :) label Jan 13, 2025
@juan-fernandez juan-fernandez marked this pull request as ready for review January 13, 2025 14:11
@juan-fernandez juan-fernandez requested review from a team as code owners January 13, 2025 14:11
tonyredondo
tonyredondo approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@tonyredondo tonyredondo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are we deprecating DD_ENV as well?

@juan-fernandez
Copy link
Contributor Author

So are we deprecating DD_ENV as well?

not deprecating, but I'd say we don't need to put in the onboarding

KickingTheTV
KickingTheTV reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@KickingTheTV KickingTheTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include somewhere why this would be of interest or when to use it? e.g. if your tests have dynamically generated names, giving a test session name will allow you to have better flaky test detection and test history

It would also be nice to include a section in Troubleshooting with this problem, and then point to this new solution

@juan-fernandez
Copy link
Contributor Author

Can you include somewhere why this would be of interest or when to use it? e.g. if your tests have dynamically generated names, giving a test session name will allow you to have better flaky test detection and test history

It would also be nice to include a section in Troubleshooting with this problem, and then point to this new solution

that's a good idea. I've just added it

@juan-fernandez juan-fernandez removed the Do Not Merge Just do not merge this PR :) label Jan 24, 2025
brett0000FF
brett0000FF approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just left two minor suggestions.

content/en/tests/troubleshooting/_index.md Outdated Show resolved Hide resolved
content/en/tests/troubleshooting/_index.md Outdated Show resolved Hide resolved
@juan-fernandez
Copy link
Contributor Author

Looks great! Just left two minor suggestions.

thanks! I applied them 😄

@juan-fernandez
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 24, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-01-24 15:29:30 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-01-24 16:04:41 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.

2025-01-24 16:15:57 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit b7a0733 into master Jan 24, 2025
14 of 18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the juan-fernandez/test-session-name-SDTEST-996 branch January 24, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brett0000FF brett0000FF brett0000FF approved these changes

@tonyredondo tonyredondo tonyredondo approved these changes

@KickingTheTV KickingTheTV Awaiting requested review from KickingTheTV

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juan-fernandez @tonyredondo @KickingTheTV @brett0000FF