Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-171] add Ruby to the list of supported languages of Datadog Jenkins plugin #26716

Merged

Conversation

anmarchenko
Copy link
Member

What does this PR do? What is the motivation?

Adds Ruby to the list of supported languages for Jenkins Plugin. Updates Jenkins Plugin settings screenshot.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

@anmarchenko anmarchenko requested review from a team as code owners December 11, 2024 11:17
@github-actions github-actions bot added the Images Images are added/removed with this PR label Dec 11, 2024
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@janine-c janine-c self-assigned this Dec 11, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anmarchenko 👋🏻 For image updates, we sometimes run into caching issues when you update images with the same filename. Could you add the new image as ci-jenkins-plugin-tests-config-2.png, and update the reference to that image with the new filename? (We have a script that will then delete the old version of the image for you.) Thank you!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, will do that!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janine-c done

Copy link
Contributor

@romainkomorn-exdatadog romainkomorn-exdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmarchenko
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 13, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-13 07:39:25 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2024-12-13 07:45:20 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 8ebda5b into master Dec 13, 2024
21 of 27 checks passed
@dd-mergequeue dd-mergequeue bot deleted the anmarchenko/jenkins_plugin_ruby_auto_instrumentation branch December 13, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants