Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update threat_intelligence.md #26712

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Update threat_intelligence.md #26712

merged 4 commits into from
Dec 11, 2024

Conversation

carlostomas-dd
Copy link
Contributor

What does this PR do? What is the motivation?

There is a typo in the Threat Intel categories documentation. It's not Tor but tor (lowercase)

We can see there are no spans with category Tor but there are a few with tor

Same happens with logs, none with Tor but many with tor

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@carlostomas-dd carlostomas-dd requested review from datamarmot and a team as code owners December 11, 2024 09:26
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlostomas-dd - Thanks for making this update! Would you be able to re-open a new PR and name your branch with the <username>/<branch name> format? Otherwise, this blocks our merge queue. Also, no need to update the Japanese docs. This change will propagate through our translation pipeline (no harm having it--it'll just get overwritten).

Let me know if you'd like any help. Thanks!

@michaelcretzman
Copy link
Contributor

michaelcretzman commented Dec 11, 2024

@carlostomas-dd I went ahead and discarded the changes to the Japanese files as these will get overwritten during translation.
I'm going to merge this PR because it contain a tiny change.

In the future, please use the <Slack username>/<branch name> format for branches. Otherwise, our merge queue is blocked and we can't merge your PR w/o overriding the requirements.

@michaelcretzman michaelcretzman merged commit 8fa40f2 into master Dec 11, 2024
11 checks passed
@michaelcretzman michaelcretzman deleted the carlostomas-dd-patch-1 branch December 11, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants