Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shared_dashboards.md #26688

Conversation

danielarodga
Copy link
Contributor

What does this PR do? What is the motivation?

Modifies the public refresh rate data shared with customers, as per this day it says that it takes around 30 seconds.

When taking a look at our internal documentation, it still says 30 seconds: https://datadoghq.atlassian.net/wiki/x/xwTGF (this is from May, 2020).

However, it seems like the code have been updated and now it has a note that it can take around 60 seconds:
https://github.com/DataDog/web-ui/blob/8258337c62d0705cacd19755c6a8196c5aba5d42/javascript/datadog/dashboard/components/Widget/WidgetAutoUpdateManager.tsx#L10

This caused confusion with my customer https://datadog.zendesk.com/agent/tickets/1955462, as it seems like they were expecting their public dashboard to refresh every 30 seconds, but when Support Agent was taking the time, it actually takes around 60 secs to be refreshed.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@danielarodga danielarodga requested a review from a team as a code owner December 10, 2024 15:23
@estherk15 estherk15 assigned estherk15 and unassigned estherk15 Dec 10, 2024
@estherk15 estherk15 added the under_review Sent to someone outside of the docs team for review. label Dec 10, 2024
@estherk15
Copy link
Contributor

estherk15 commented Dec 10, 2024

@danielarodga Thanks for looking into this and updating the docs! Confirmed with the dashboards team, this is good to go!

@estherk15 estherk15 removed the under_review Sent to someone outside of the docs team for review. label Dec 10, 2024
@estherk15
Copy link
Contributor

@danielarodga, could you reopen this PR with the following branch name: danielarodriguez/update_shared_dashboards_refresh_rate

@danielarodga danielarodga deleted the danielarodriguez-update_shared_dashboards_refresh_rate branch December 10, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants