-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new guide for using Vega-Lite in Wildcard widget #26665
Add new guide for using Vega-Lite in Wildcard widget #26665
Conversation
Preview links (active after the
|
content/en/dashboards/guide/using_vega_lite_in_wildcard_widgets.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @estherk15 this looks good just a few small suggestions ;)
content/en/dashboards/guide/using_vega_lite_in_wildcard_widgets.md
Outdated
Show resolved
Hide resolved
content/en/dashboards/guide/using_vega_lite_in_wildcard_widgets.md
Outdated
Show resolved
Hide resolved
content/en/dashboards/guide/using_vega_lite_in_wildcard_widgets.md
Outdated
Show resolved
Hide resolved
content/en/dashboards/guide/using_vega_lite_in_wildcard_widgets.md
Outdated
Show resolved
Hide resolved
content/en/dashboards/guide/using_vega_lite_in_wildcard_widgets.md
Outdated
Show resolved
Hide resolved
content/en/dashboards/guide/using_vega_lite_in_wildcard_widgets.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Alicia Scott <[email protected]>
Thanks so much for catching those edits @aliciascott! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
/merge |
Devflow running:
|
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes