Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new guide for using Vega-Lite in Wildcard widget #26665

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

estherk15
Copy link
Contributor

@estherk15 estherk15 commented Dec 6, 2024

What does this PR do? What is the motivation?

  • Add a new guide on using Vega-Lite in Wildcard widget
  • DOCS-9318

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@estherk15 estherk15 added the WORK IN PROGRESS No review needed, it's a wip ;) label Dec 6, 2024
@estherk15 estherk15 requested a review from a team as a code owner December 6, 2024 21:30
@github-actions github-actions bot added the Guide Content impacting a guide label Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

@estherk15 estherk15 removed the WORK IN PROGRESS No review needed, it's a wip ;) label Dec 9, 2024
@github-actions github-actions bot added the Images Images are added/removed with this PR label Dec 9, 2024
@estherk15 estherk15 added the editorial review Waiting on a more in-depth review label Dec 9, 2024
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @estherk15 this looks good just a few small suggestions ;)

@estherk15
Copy link
Contributor Author

Thanks so much for catching those edits @aliciascott!

Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@estherk15
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 10, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-10 21:28:35 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-10 21:44:57 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review Guide Content impacting a guide Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants