Add FIPS-specific JMXFetch documentation #26624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
brett0000FF
requested changes
Dec 11, 2024
| @@ -0,0 +1,151 @@ | |||
| # JMXFetch FIPS-140 mode | |||
There was a problem hiding this comment.
Could you please add a new entry for this guide to content/en/integrations/guide/_index.md too? Thanks!
Comment on lines
123
to
125
| See application documentation for specific instructions about how to configure JMX properties. At least the | ||
| following properties must to be set. Adjust paths as needed to point to actual location of the key and trust | ||
| store files. |
There was a problem hiding this comment.
Suggested change
| See application documentation for specific instructions about how to configure JMX properties. At least the | |
| following properties must to be set. Adjust paths as needed to point to actual location of the key and trust | |
| store files. | |
| See application documentation for specific instructions about how to configure JMX properties. Add these JMX properties to your application configuration. Adjust the paths to your key and trust store files. |
Can we add a link to the application documentation we're referring to?
There was a problem hiding this comment.
Noted, appreciate the context.
| following properties must to be set. Adjust paths as needed to point to actual location of the key and trust | ||
| store files. | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Suggested change
| ``` | |
| ```text |
Co-authored-by: Brett Blue <[email protected]>
brett0000FF
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
@vickenty - Thanks, looks good! Heads up, I pushed a small commit where I indented the shell commands so they are inline with the numbered list.
Feel free to add this to the merge queue with /merge or ping me, and I can merge it. 👍
Co-authored-by: Brett Blue <[email protected]>
This reverts commit 30c60fb. Adds duplicate content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes