Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable docs implementation #23971

Draft
wants to merge 502 commits into
base: master
Choose a base branch
from
Draft

Customizable docs implementation #23971

wants to merge 502 commits into from

Conversation

jhgilbert
Copy link
Contributor

What does this PR do? What is the motivation?

Merge instructions

  • Please merge after reviewing

Additional notes

@jhgilbert jhgilbert added WORK IN PROGRESS No review needed, it's a wip ;) Do Not Merge Just do not merge this PR :) labels Jul 2, 2024
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jul 2, 2024
@github-actions github-actions bot removed the Architecture Everything related to the Doc backend label Jul 12, 2024
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024 •
edited
Loading

Preview links (active after the build_preview check completes)

New or renamed files

@jhgilbert
Add migration analysis script
0ac209a
@jhgilbert
Add gitignore file
3149112
@jhgilbert
Merge branch 'jen.gilbert/customizable-docs-implementation' into jen.…
6ebe1aa 
…gilbert/customizable-docs-allowlist
@jhgilbert
Update JA test site to use translated allowlist
9b911b8
@jhgilbert
Add overrides
6ce4dfc
@jhgilbert
Migrate test pages to allowlist
9f09743
@jhgilbert
Delete unnecessary file
78968d1
@jhgilbert
Update test snapshots
0765595
@jhgilbert
Delete blank file
89434ed
@jhgilbert
Write PagePrefManifest schema
b1f2679
@jhgilbert
Tweak prefs manifest schema
291c442
@jhgilbert
Finish creating initial prefs manifest object
a875c39
@jhgilbert
Add the referenced options sets to the prefs manifest
65c909d
@jhgilbert
Add invalid placeholder detection
ac34b48
@jhgilbert
Add invalid placeholder detection
5943654
@jhgilbert
Update error snapshots
80ab321
@jhgilbert
Add initial values to the prefs manifest
c7fbb46
@jhgilbert
Integrate prefs manifest into top-level page build function
940a119
@jhgilbert
[wip] Integrate the prefs manifest
bbbfe71
@jhgilbert
Tweak approach to default values
4d8a86d
@jhgilbert
Migrate the PageTemplate to the prefs manifest
79dc96f
@jhgilbert
Add possible values to the prefs manifest
e7b5141
@jhgilbert
Remove unnecessary arg
031efc2
@jhgilbert
Add simple 'impossible value' validation
e513690
@jhgilbert
Update test snapshots
c9de257
@jhgilbert
Rename ContentFilter -> CustomizationMenu for clarity
7493672
@jhgilbert
Break selector build into its own function to prep for migration to d…
ea5198f 
…ropdowns
@jhgilbert
Add dropdown styles to integration CSS
be6623c
@jhgilbert
Reorganize CSS styles
8a358fd
@jhgilbert
Use consistent CSS prefixes
d6117e0
@jhgilbert
Sketch in dropdown rendering function
e1ce27e
@jhgilbert
[wip] Migrate the customization menu to dropdowns
2a14139
@jhgilbert
Toggle dropdown item list display when parent button is clicked
ed6e6c2
@jhgilbert
Refactor
e66c6f0
@jhgilbert
Refactor
3e2b8d5
@jhgilbert
Handle outside clicks
0aa180f
@jhgilbert
Tweak dropdown widths
d64239f
@jhgilbert
Refactor
1223df8
@jhgilbert
[wip] Add ARIA labels
c4a7cd5
@jhgilbert
Add ARIA attributes
f260186
@jhgilbert
Minor tweaks
804601a
@jhgilbert
Fix page rendering bug for non-customizable pages
4ee20ec
@jhgilbert
Update test snapshots
866e1bd
@jhgilbert
Sync menu design page with live HTML
565b283
@jhgilbert
Add pills menu to design sketch page
d710ad4
@jhgilbert
Sketch in pill menu builder function
4ecdc03
@jhgilbert
Finish initial pill menu design
37ea3dd
@jhgilbert
Switch back to dropdowns to prep for merge into the main feature branch
cd30ad6
@jhgilbert
Purposely allow the pills menu to overflow the page
f432851
@jhgilbert
Build entire pills menu in a separate function
3f4857a
@jhgilbert
Switch to dropdowns on initial menu load if pills are too wide
b31eec5
@jhgilbert
Handle resize events
6e018bb
@jhgilbert
Finish drafting hybrid menu
7fefe76
@jhgilbert
Rebuild assets
d5b7017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend Do Not Merge Just do not merge this PR :) WORK IN PROGRESS No review needed, it's a wip ;)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhgilbert @devindford