Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS-6870] Add OP SDS transform guide #20962
[DOCS-6870] Add OP SDS transform guide #20962
Changes from 3 commits
ce5b55d
a72ce11
0d5b836
54877c9
0b0ebbc
3f8d5b7
6cafef3
d11801e
bf647e6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check notice on line 20 in content/en/observability_pipelines/guide/sensitive_data_scanner_transform.md
GitHub Actions / vale
[vale] content/en/observability_pipelines/guide/sensitive_data_scanner_transform.md#L20
Raw output
Check notice on line 20 in content/en/observability_pipelines/guide/sensitive_data_scanner_transform.md
GitHub Actions / vale
[vale] content/en/observability_pipelines/guide/sensitive_data_scanner_transform.md#L20
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The supported syntax is a subset of PCRE2. I have compiled an exhaustive list of exactly what is supported if that helps here at all: https://datadoghq.atlassian.net/wiki/spaces/SDS/pages/3221292288/SDS+Regex+Syntax
Just note that the syntax listed above is what the Core SDS library supports. OPW is currently using a different implementation (which is NOT PCRE or PCRE2 compliant) but it will be switched out very soon (likely next week).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fuchsnj, good to know! I'd like to publish this doc this week, do you think it makes sense to remove this information for now, and then add it back when OPW has switched to be PCRE2 compliant?
Also, thanks for the confluence link. At some point, it seems we should have public documentation on what regex syntax is supported? Is it usually so specific what syntax is available? Or can we point them to the regex101.com site you mention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably fine to keep it as PCRE2 for now. The differences are fairly subtle and not something users are likely to notice.
That confluence doc is mostly for internal documentation now, and to help write any public documentation whenever that happens. I don't expect you to include the whole thing here. I expect in the future we will probably have more detailed public docs about the regex syntax in the SDS docs that you could link to here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks for the info!