Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip crashtracking specs in Github Actions #4378

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Feb 13, 2025

What does this PR do?

Enable some crashtracking specs which I previous thought might be flaky

Change log entry

None.

@TonyCTHsu TonyCTHsu added dev/testing Involves testing processes (e.g. RSpec) dev/github Github repository maintenance and automation labels Feb 13, 2025
Copy link

github-actions bot commented Feb 13, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-02-13 15:18:01 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 13, 2025

Datadog Report

Branch report: tonycthsu/gha-flake
Commit report: 20e6aa7
Test service: dd-trace-rb

✅ 0 Failed, 22454 Passed, 1481 Skipped, 7m 4.3s Total Time
⌛ 1 Performance Regression

⌛ Performance Regressions vs Default Branch (1)

  • Rails integration tests for an application with a basic route behaves like appsec standalone billing without upstream appsec propagation with attack and trace is kept with priority 2 from 0 sampling priority behaves like a trace sent to agent with Datadog-Client-Computed-Stats header is expected to equal true - rspec 3.8s (+3.2s, +531%) - Details

@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2025

Benchmarks

Benchmark execution time: 2025-02-13 15:38:40

Comparing candidate commit 20e6aa7 in PR branch tonycthsu/gha-flake with baseline commit 44bbcc1 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu changed the title Unskip crashtracking, telemetery specs in Github Actions Unskip crashtracking specs in Github Actions Feb 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (44bbcc1) to head (20e6aa7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4378      +/-   ##
==========================================
+ Coverage   97.65%   97.69%   +0.03%     
==========================================
  Files        1351     1351              
  Lines       82696    82697       +1     
  Branches     4198     4198              
==========================================
+ Hits        80760    80791      +31     
+ Misses       1936     1906      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu marked this pull request as ready for review February 13, 2025 16:01
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner February 13, 2025 16:01
Copy link
Contributor

@sarahchen6 sarahchen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@sarahchen6 sarahchen6 merged commit abc6008 into master Feb 13, 2025
496 checks passed
@sarahchen6 sarahchen6 deleted the tonycthsu/gha-flake branch February 13, 2025 18:10
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants