Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload coverage to codecov #4373

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Upload coverage to codecov #4373

merged 2 commits into from
Feb 13, 2025

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Feb 12, 2025

What does this PR do?

Upload coverage report to codecov from Github Actions

Change log entry
None

Copy link

github-actions bot commented Feb 12, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-02-12 15:13:38 UTC

@TonyCTHsu TonyCTHsu added the dev/github Github repository maintenance and automation label Feb 12, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 12, 2025

Datadog Report

Branch report: tonycthsu/coverage
Commit report: c47ee3e
Test service: dd-trace-rb

✅ 0 Failed, 22081 Passed, 1478 Skipped, 6m 7.52s Total Time
⌛ 10 Performance Regressions

⌛ Performance Regressions vs Default Branch (10)

This report shows up to 5 performance regressions.

  • Rails integration tests for an application with a basic route GET request with a non-event-triggering request behaves like a trace without AppSec events is expected to be nil - rspec 4.38s (+3.78s, +622%) - Details
  • Rails integration tests for an application with a basic route GET request with an event-triggering request in IP behaves like a GET 403 span is expected to eq 0 - rspec 4.45s (+3.85s, +651%) - Details
  • Rails integration tests for an application with a basic route GET request with user blocking ID behaves like a trace with AppSec api security tags with api security enabled is expected not to be empty - rspec 3.26s (+2.66s, +444%) - Details
  • Rails integration tests for an application with a basic route GET request with an event-triggering request in IP behaves like a trace with AppSec tags is expected to eq "1.2.3.4" - rspec 4.71s (+4.13s, +707%) - Details
  • Rails integration tests for an application with a basic route GET request with an event-triggering request in IP behaves like a trace with AppSec api security tags with api security enabled is expected not to be empty - rspec 5.08s (+4.49s, +763%) - Details

@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2025

Benchmarks

Benchmark execution time: 2025-02-13 09:21:53

Comparing candidate commit c47ee3e in PR branch tonycthsu/coverage with baseline commit 20886bc in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (20886bc) to head (c47ee3e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4373      +/-   ##
==========================================
- Coverage   97.74%   97.66%   -0.09%     
==========================================
  Files        1351     1351              
  Lines       82697    82696       -1     
  Branches     4198     4198              
==========================================
- Hits        80831    80762      -69     
- Misses       1866     1934      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu marked this pull request as ready for review February 13, 2025 08:58
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner February 13, 2025 08:58
@TonyCTHsu TonyCTHsu enabled auto-merge February 13, 2025 09:04
@TonyCTHsu TonyCTHsu merged commit 5858773 into master Feb 13, 2025
495 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/coverage branch February 13, 2025 09:31
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants