Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(propagation): otel baggage support #4371

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ZStriker19
Copy link
Contributor

What does this PR do?
Following the spec here: https://www.w3.org/TR/baggage/ we implement baggage propagation for the Ruby tracer
Motivation:

Change log entry

Additional Notes:

How to test the change?

Copy link

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-02-11 22:38:59 UTC

@ZStriker19 ZStriker19 force-pushed the zachg/baggage_support branch from e9d741c to eee20a9 Compare February 11, 2025 22:55
@github-actions github-actions bot added the integrations Involves tracing integrations label Feb 11, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 11, 2025

Datadog Report

Branch report: zachg/baggage_support
Commit report: 1482be0
Test service: dd-trace-rb

✅ 0 Failed, 22487 Passed, 1507 Skipped, 5m 51s Total Time

@ZStriker19 ZStriker19 force-pushed the zachg/baggage_support branch from eee20a9 to 751ca10 Compare February 12, 2025 19:47
@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2025

Benchmarks

Benchmark execution time: 2025-02-13 22:28:50

Comparing candidate commit 1482be0 in PR branch zachg/baggage_support with baseline commit 20886bc in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-0.541op/s; -0.532op/s] or [-8.325%; -8.193%]

scenario:tracing - Propagation - Trace Context

  • 🟩 throughput [+3513.570op/s; +3603.401op/s] or [+10.178%; +10.438%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant