-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SSI #4366
base: master
Are you sure you want to change the base?
Improve SSI #4366
Conversation
👋 Hey @lloeki, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md (possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None. (possible answers No/Nope/None) Visited at: 2025-02-12 10:56:12 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 22083 Passed, 1476 Skipped, 5m 19.71s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4366 +/- ##
==========================================
+ Coverage 97.73% 97.77% +0.04%
==========================================
Files 1368 1372 +4
Lines 83014 84650 +1636
Branches 4221 4400 +179
==========================================
+ Hits 81134 82770 +1636
Misses 1880 1880 ☔ View full report in Codecov by Sentry. |
Ruby 2.6 showed up a lot in telemetry.
What does this PR do?
General improvements to the current SSI injector bootstrap implementation
Motivation:
Some things are not quite covered.
Change log entry
Additional Notes:
How to test the change?
It's a bit hard right now, either we have small granularity CI but a lot of environmental invasion (rspec) or we have isolation but coarse granularity (vaccine). Working on it.
#4366