Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linting rule for list first/last #4364

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Remove linting rule for list first/last #4364

merged 2 commits into from
Feb 11, 2025

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Feb 11, 2025

This rule has been mostly ignored, since it doesn't always provide idiomatic Ruby.

Change log entry
No.

@marcotc marcotc added the dev/internal Other internal work that does not need to be included in the changelog label Feb 11, 2025
@marcotc marcotc requested a review from a team as a code owner February 11, 2025 00:35
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 11, 2025

Datadog Report

Branch report: lint-first
Commit report: 080de1b
Test service: dd-trace-rb

✅ 0 Failed, 22065 Passed, 1477 Skipped, 5m 27.86s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (9945a09) to head (080de1b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4364   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files        1348     1348           
  Lines       82508    82508           
  Branches     4199     4199           
=======================================
+ Hits        80644    80649    +5     
+ Misses       1864     1859    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2025

Benchmarks

Benchmark execution time: 2025-02-11 09:35:06

Comparing candidate commit 080de1b in PR branch lint-first with baseline commit 9945a09 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟩 throughput [+0.509op/s; +0.518op/s] or [+8.562%; +8.729%]

scenario:tracing - Propagation - Trace Context

  • 🟩 throughput [+3539.127op/s; +3649.856op/s] or [+10.240%; +10.560%]

@TonyCTHsu TonyCTHsu enabled auto-merge February 11, 2025 09:20
@TonyCTHsu TonyCTHsu merged commit 5c1cea4 into master Feb 11, 2025
493 checks passed
@TonyCTHsu TonyCTHsu deleted the lint-first branch February 11, 2025 09:36
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants