-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reactive engine from AppSec rack instrumentation #4355
Conversation
bec1d33
to
325ffae
Compare
Datadog ReportBranch report: ✅ 0 Failed, 22028 Passed, 1476 Skipped, 5m 39.76s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4355 +/- ##
==========================================
- Coverage 97.72% 97.72% -0.01%
==========================================
Files 1368 1348 -20
Lines 83014 82401 -613
Branches 4221 4195 -26
==========================================
- Hits 81124 80523 -601
+ Misses 1890 1878 -12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢🔴🔴🔴 🚀
BenchmarksBenchmark execution time: 2025-02-06 17:27:37 Comparing candidate commit 325ffae in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiler - sample timeline=false
|
What does this PR do?
It removes
Datadog::AppSec::Reactive::Engine
.Motivation:
The problem with reactive engine was that it was not used the way it was intended, and therefore only added unnecessary complexity to our code.
Change log entry
None, this is internal change.
Additional Notes:
None.
How to test the change?
CI and manual testing with app generator.