Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reactive engine from AppSec rack instrumentation #4355

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

y9v
Copy link
Member

@y9v y9v commented Feb 6, 2025

What does this PR do?
It removes Datadog::AppSec::Reactive::Engine.

Motivation:
The problem with reactive engine was that it was not used the way it was intended, and therefore only added unnecessary complexity to our code.

Change log entry
None, this is internal change.

Additional Notes:
None.

How to test the change?
CI and manual testing with app generator.

@y9v y9v self-assigned this Feb 6, 2025
@y9v y9v requested a review from a team as a code owner February 6, 2025 15:51
@github-actions github-actions bot added integrations Involves tracing integrations appsec Application Security monitoring product labels Feb 6, 2025
@y9v y9v force-pushed the appsec-remove-reactive-engine branch from bec1d33 to 325ffae Compare February 6, 2025 16:01
@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: appsec-remove-reactive-engine
Commit report: 325ffae
Test service: dd-trace-rb

✅ 0 Failed, 22028 Passed, 1476 Skipped, 5m 39.76s Total Time

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.78049% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.72%. Comparing base (e1c3be1) to head (325ffae).

Files with missing lines Patch % Lines
lib/datadog/appsec/contrib/rack/gateway/watcher.rb 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4355      +/-   ##
==========================================
- Coverage   97.72%   97.72%   -0.01%     
==========================================
  Files        1368     1348      -20     
  Lines       83014    82401     -613     
  Branches     4221     4195      -26     
==========================================
- Hits        81124    80523     -601     
+ Misses       1890     1878      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢🔴🔴🔴 🚀

@Strech Strech added the dev/internal Other internal work that does not need to be included in the changelog label Feb 6, 2025
@pr-commenter
Copy link

pr-commenter bot commented Feb 6, 2025

Benchmarks

Benchmark execution time: 2025-02-06 17:27:37

Comparing candidate commit 325ffae in PR branch appsec-remove-reactive-engine with baseline commit e1c3be1 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟩 throughput [+0.581op/s; +0.588op/s] or [+9.728%; +9.854%]

@y9v y9v merged commit 8295f62 into master Feb 7, 2025
492 checks passed
@y9v y9v deleted the appsec-remove-reactive-engine branch February 7, 2025 07:56
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product dev/internal Other internal work that does not need to be included in the changelog integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants