Add meta_struct support on traces and spans #4334
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpellan
force-pushed
the
vpellan/meta-struct
branch
from
b9e8d5d to
b3dc5c2
Compare
vpellan
force-pushed
the
vpellan/meta-struct
branch
from
b3dc5c2 to
0836e11
Compare
Datadog ReportBranch report: ✅ 0 Failed, 22101 Passed, 1476 Skipped, 5m 15.08s Total Time |
BenchmarksBenchmark execution time: 2025-01-31 13:12:18 Comparing candidate commit 0836e11 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiler - stack collector
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4334 +/- ##
==========================================
- Coverage 97.72% 97.71% -0.02%
==========================================
Files 1368 1369 +1
Lines 82998 83027 +29
Branches 4220 4222 +2
==========================================
+ Hits 81108 81126 +18
- Misses 1890 1901 +11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds meta_struct support to traces and spans. meta_struct is a way to send complex structures to the backend. It is sent as a Map<String, ByteArray> with the ByteArray being the structure encoded in messagepack.
Motivation:
meta_struct is required for stack trace collection, which is required for exploit prevention. But this can also be used by other products.
Change log entry
None.
Additional Notes:
How to test the change?