Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official parametric scenario parameters #4332

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

cbeauchesne
Copy link
Contributor

What does this PR do?
Use official parametric scenario parameters

Motivation:
previously known as experimental, those parameters are now officials, and old ones are removed

Change log entry

Additional Notes:

How to test the change?

@cbeauchesne cbeauchesne requested a review from a team as a code owner January 31, 2025 08:34
@cbeauchesne cbeauchesne marked this pull request as draft January 31, 2025 08:34
Copy link

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-01-31 08:35:05 UTC

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Jan 31, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: cbeauchesne/system-tests-parameter
Commit report: 50119f9
Test service: dd-trace-rb

✅ 0 Failed, 22119 Passed, 1476 Skipped, 5m 24.56s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (5cb85a0) to head (50119f9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4332   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files        1368     1368           
  Lines       82998    82998           
  Branches     4220     4220           
=======================================
+ Hits        81110    81111    +1     
+ Misses       1888     1887    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 31, 2025

Benchmarks

Benchmark execution time: 2025-01-31 08:58:00

Comparing candidate commit 50119f9 in PR branch cbeauchesne/system-tests-parameter with baseline commit 5cb85a0 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@cbeauchesne cbeauchesne marked this pull request as ready for review January 31, 2025 09:17
@lloeki lloeki merged commit cefebdf into master Jan 31, 2025
388 checks passed
@lloeki lloeki deleted the cbeauchesne/system-tests-parameter branch January 31, 2025 10:27
@github-actions github-actions bot added this to the 2.10.0 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants