Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate checks #4328

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Aggregate checks #4328

merged 1 commit into from
Jan 29, 2025

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

  1. Group those static checks to reduce the amount of YAML files.
  2. Upgrade ubuntu runner
  3. Upgrade Ruby images
  4. Share the same lockfile
  5. Remove obsolete keys dd_service and dd_env

Change log entry
None.

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Jan 29, 2025
@TonyCTHsu TonyCTHsu marked this pull request as ready for review January 29, 2025 15:30
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner January 29, 2025 15:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (8dba6cb) to head (b2893dd).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4328   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files        1368     1368           
  Lines       82997    82998    +1     
  Branches     4219     4219           
=======================================
+ Hits        81105    81111    +6     
+ Misses       1892     1887    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 29, 2025

Benchmarks

Benchmark execution time: 2025-01-29 15:41:29

Comparing candidate commit b2893dd in PR branch tonycthsu/consolidate-checks with baseline commit 8dba6cb in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:tracing - Tracing.log_correlation

  • 🟩 throughput [+9336.172op/s; +9659.482op/s] or [+8.593%; +8.891%]

@TonyCTHsu TonyCTHsu merged commit 258f0db into master Jan 29, 2025
385 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/consolidate-checks branch January 29, 2025 15:48
@github-actions github-actions bot added this to the 2.10.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants