Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Datadog.configuration.appsec.rasp_enabled #4311

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

y9v
Copy link
Member

@y9v y9v commented Jan 22, 2025

What does this PR do?
It adds DD_APPSEC_RASP_ENABLED setting to AppSec for disabling RASP.

Motivation:
This RFC

Change log entry
Yes. AppSec: Add setting to disable RASP checks

Additional Notes:
None.

How to test the change?
CI is enough

@y9v y9v self-assigned this Jan 22, 2025
@y9v y9v requested a review from a team as a code owner January 22, 2025 15:40
@github-actions github-actions bot added integrations Involves tracing integrations appsec Application Security monitoring product labels Jan 22, 2025
Copy link

github-actions bot commented Jan 22, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-01-22 15:41:49 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 22, 2025

Datadog Report

Branch report: appsec-add-rasp-enabled-config
Commit report: c0da9a0
Test service: dd-trace-rb

✅ 0 Failed, 22099 Passed, 1476 Skipped, 6m 24.74s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 98.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.72%. Comparing base (a49a11c) to head (65e8bfb).

Files with missing lines Patch % Lines
...c/contrib/active_record/postgresql_adapter_spec.rb 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4311      +/-   ##
==========================================
+ Coverage   97.71%   97.72%   +0.01%     
==========================================
  Files        1365     1365              
  Lines       82726    82780      +54     
  Branches     4205     4206       +1     
==========================================
+ Hits        80833    80895      +62     
+ Misses       1893     1885       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 22, 2025

Benchmarks

Benchmark execution time: 2025-01-24 09:10:03

Comparing candidate commit 65e8bfb in PR branch appsec-add-rasp-enabled-config with baseline commit a49a11c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree to put it inside the instrumentation level until we find a better way to not assemble data if RASP is disabled.

It's tempting to move it into the Context.run_rasp method, but performance wise, it means we will assemble data for WAF without a need and it might be costly

@y9v y9v force-pushed the appsec-add-rasp-enabled-config branch from d4793b5 to 87c14cd Compare January 22, 2025 16:40
@marcotc
Copy link
Member

marcotc commented Jan 22, 2025

One question: what is rasp? I can't documentation for it in our source code. If one doesn't exist, can we add a short blurb explaining what is it? (anywhere is fine)

@Strech
Copy link
Member

Strech commented Jan 23, 2025

@marcotc RASP is a new term used in AppSec and it means Runtime Application Self-Protection

@y9v
Copy link
Member Author

y9v commented Jan 23, 2025

@marcotc I added an explanation in a comment in appsec/configuration/settings.rb: c0da9a0

@y9v y9v enabled auto-merge January 24, 2025 08:44
@y9v y9v force-pushed the appsec-add-rasp-enabled-config branch from c0da9a0 to 65e8bfb Compare January 24, 2025 08:46
@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: appsec-add-rasp-enabled-config
Commit report: 65e8bfb
Test service: dd-trace-rb

✅ 0 Failed, 22094 Passed, 1477 Skipped, 5m 34.56s Total Time

@y9v y9v merged commit a72b341 into master Jan 24, 2025
378 checks passed
@y9v y9v deleted the appsec-add-rasp-enabled-config branch January 24, 2025 09:11
@github-actions github-actions bot added this to the 2.10.0 milestone Jan 24, 2025
@TonyCTHsu TonyCTHsu mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants