Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply docs changes from #3446 to master #3525

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Mar 14, 2024

What does this PR do?

This PR brings the changes from #3446 that were directly applied to our docs ("release" branch) into the master branch.

Motivation:

This makes sure the changes don't get lost during the release process.

Additional Notes:

N/A

How to test the change?

Check diff looks good :)

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

adds reference to private beta in order to ensure use env var correctly
@ivoanjo ivoanjo requested a review from a team as a code owner March 14, 2024 15:40
@github-actions github-actions bot added the docs Involves documentation label Mar 14, 2024
@ivoanjo
Copy link
Member Author

ivoanjo commented Mar 14, 2024

Note to self: Remember to cherry-pick this to release branch after merging to master.

@ivoanjo ivoanjo merged commit 6b85e19 into master Mar 14, 2024
220 checks passed
@ivoanjo ivoanjo deleted the ivoanjo/apply-gettingstarted-change-in-master branch March 14, 2024 17:26
@github-actions github-actions bot added this to the 1.22.0 milestone Mar 14, 2024
@ivoanjo
Copy link
Member Author

ivoanjo commented Mar 14, 2024

Thanks Marco for the review! I've gone ahead and pushed this to the release branch as well, so the docs change should show up again shortly :)

(And since I pushed the exact hash that's in master, it won't cause conflicts for next version :D)

@TonyCTHsu TonyCTHsu modified the milestones: 1.22.0, 1.21.1 Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants