Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code owners to capture deep changes and force absolute paths #3363

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

AlexJF
Copy link
Contributor

@AlexJF AlexJF commented Jan 4, 2024

What does this PR do?
Existing code owners did not work as intended with changes exclusive to deep nested files and may match on unintended files due to lack of absolute path usage (e.g. any nested ext dir would be attributed to profiling).

Refer to the example to see why the existing rules were wrong:


# The `docs/*` pattern will match files like
# `docs/getting-started.md` but not further nested files like
# `docs/build-app/troubleshooting.md`.
docs/*  [email protected]

# In this example, @octocat owns any file in an apps directory
# anywhere in your repository.
apps/ @octocat

# In this example, @doctocat owns any file in the `/docs`
# directory in the root of your repository and any of its
# subdirectories.
/docs/ @doctocat

Motivation:
Proper tagging of relevant reviewers. Here's an example where the existing rules did not target @Datadog/profiling-rb but should have: #3352

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@AlexJF AlexJF requested a review from a team as a code owner January 4, 2024 18:06
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Jan 4, 2024
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM thanks for spotting this!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5899696) 98.24% compared to head (ac1f680) 98.24%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3363   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files        1254     1254           
  Lines       73198    73198           
  Branches     3430     3430           
=======================================
+ Hits        71910    71911    +1     
+ Misses       1288     1287    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexJF AlexJF merged commit 7b996fc into master Jan 5, 2024
219 checks passed
@AlexJF AlexJF deleted the alexjf/fix-code-owners branch January 5, 2024 11:08
@github-actions github-actions bot added this to the 1.19.0 milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants