[APPSEC-9143] Extract expires information from target map payload. #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoCaso
changed the title
GustavoCaso
force-pushed
the
remote-check-expires-information
branch
from
64656b2 to
da4cbe6
Compare
Propagate expires information to content instances. Make sure to remove content information from `config_state` when content has expire.
GustavoCaso
force-pushed
the
remote-check-expires-information
branch
from
da4cbe6 to
888514d
Compare
GustavoCaso
commented
Apr 18, 2023
| @@ -90,8 +91,12 @@ def initialize(repository) | |||
| def contents_to_config_states(contents) | |||
| return [] if contents.empty? | |||
|
|
|||
| contents.map do |content| | |||
| { | |||
| contents.each_with_object([]) do |content, acc| | |||
There was a problem hiding this comment.
I had to change it to each_with_object because steep was complaining about using map and next
ivoanjo
reviewed
Apr 18, 2023
|
|
||
| map = new | ||
|
|
||
| map.instance_eval do | ||
| @opaque_backend_state = opaque_backend_state | ||
| @version = version | ||
| @expires = DateTime.iso8601(expires) if expires |
There was a problem hiding this comment.
|
Is this PR still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Propagate expires information to content instances.
Make sure to remove content information from
config_statewhen content has expired.Motivation
The
config_statesinformation have to change based on expiration informationAdditional Notes
How to test the change?
CI