WIP

DataDog · Feb 11, 2025 · 39b6d8a · 39b6d8a
1 parent 78f99a9
commit 39b6d8a
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 11 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -146,7 +146,8 @@ jobs:
       uses: mxschmitt/action-tmate@e5c7151931ca95bad1c6f4190c730ecf8c7dde48
       with:
         limit-access-to-actor: true
-    - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
+    - if: always()
+      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
       with:
         name: junit-ruby-34-${{ matrix.batch }}-${{ github.run_id }}
         path: tmp/rspec/*.xml
@@ -280,7 +281,8 @@ jobs:
       uses: mxschmitt/action-tmate@e5c7151931ca95bad1c6f4190c730ecf8c7dde48
       with:
         limit-access-to-actor: true
-    - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
+    - if: always()
+      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
       with:
         name: junit-ruby-33-${{ matrix.batch }}-${{ github.run_id }}
         path: tmp/rspec/*.xml
@@ -414,7 +416,8 @@ jobs:
       uses: mxschmitt/action-tmate@e5c7151931ca95bad1c6f4190c730ecf8c7dde48
       with:
         limit-access-to-actor: true
-    - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
+    - if: always()
+      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
       with:
         name: junit-ruby-32-${{ matrix.batch }}-${{ github.run_id }}
         path: tmp/rspec/*.xml
@@ -548,7 +551,8 @@ jobs:
       uses: mxschmitt/action-tmate@e5c7151931ca95bad1c6f4190c730ecf8c7dde48
       with:
         limit-access-to-actor: true
-    - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
+    - if: always()
+      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
       with:
         name: junit-ruby-31-${{ matrix.batch }}-${{ github.run_id }}
         path: tmp/rspec/*.xml
@@ -682,7 +686,8 @@ jobs:
       uses: mxschmitt/action-tmate@e5c7151931ca95bad1c6f4190c730ecf8c7dde48
       with:
         limit-access-to-actor: true
-    - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
+    - if: always()
+      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
       with:
         name: junit-ruby-30-${{ matrix.batch }}-${{ github.run_id }}
         path: tmp/rspec/*.xml
@@ -816,7 +821,8 @@ jobs:
       uses: mxschmitt/action-tmate@e5c7151931ca95bad1c6f4190c730ecf8c7dde48
       with:
         limit-access-to-actor: true
-    - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
+    - if: always()
+      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
       with:
         name: junit-ruby-27-${{ matrix.batch }}-${{ github.run_id }}
         path: tmp/rspec/*.xml
@@ -950,7 +956,8 @@ jobs:
       uses: mxschmitt/action-tmate@e5c7151931ca95bad1c6f4190c730ecf8c7dde48
       with:
         limit-access-to-actor: true
-    - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
+    - if: always()
+      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
       with:
         name: junit-ruby-26-${{ matrix.batch }}-${{ github.run_id }}
         path: tmp/rspec/*.xml
@@ -1084,7 +1091,8 @@ jobs:
       uses: mxschmitt/action-tmate@e5c7151931ca95bad1c6f4190c730ecf8c7dde48
       with:
         limit-access-to-actor: true
-    - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
+    - if: always()
+      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
       with:
         name: junit-ruby-25-${{ matrix.batch }}-${{ github.run_id }}
         path: tmp/rspec/*.xml
@@ -1218,7 +1226,8 @@ jobs:
       uses: mxschmitt/action-tmate@e5c7151931ca95bad1c6f4190c730ecf8c7dde48
       with:
         limit-access-to-actor: true
-    - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
+    - if: always()
+      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
       with:
         name: junit-jruby-94-${{ matrix.batch }}-${{ github.run_id }}
         path: tmp/rspec/*.xml
@@ -1352,7 +1361,8 @@ jobs:
       uses: mxschmitt/action-tmate@e5c7151931ca95bad1c6f4190c730ecf8c7dde48
       with:
         limit-access-to-actor: true
-    - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
+    - if: always()
+      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
       with:
         name: junit-jruby-93-${{ matrix.batch }}-${{ github.run_id }}
         path: tmp/rspec/*.xml
@@ -1486,7 +1496,8 @@ jobs:
       uses: mxschmitt/action-tmate@e5c7151931ca95bad1c6f4190c730ecf8c7dde48
       with:
         limit-access-to-actor: true
-    - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
+    - if: always()
+      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
       with:
         name: junit-jruby-92-${{ matrix.batch }}-${{ github.run_id }}
         path: tmp/rspec/*.xml
@@ -1507,6 +1518,7 @@ jobs:
     steps:
     - run: echo "DONE!"
   upload-junit:
+    if: always()
     runs-on: ubuntu-24.04
     container:
       image: datadog/ci

diff --git a/spec/datadog/tracing/contrib/sidekiq/configuration/settings_spec.rb b/spec/datadog/tracing/contrib/sidekiq/configuration/settings_spec.rb
@@ -3,4 +3,7 @@
 
 RSpec.describe Datadog::Tracing::Contrib::Sidekiq::Configuration::Settings do
   it_behaves_like 'with on_error setting'
+  it 'WIP', pending: true do
+    expect(0).to eq(0)
+  end
 end
diff --git a/tasks/github.rake b/tasks/github.rake
@@ -226,6 +226,7 @@ namespace :github do
               }
             },
             {
+              'if' => 'always()',
               'uses' => 'actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08',
               'with' => {
                 'name' => runtime.junit_artifact,
@@ -267,6 +268,7 @@ namespace :github do
             ]
           },
           'upload-junit' => {
+            'if' => 'always()',
             'runs-on' => ubuntu,
             'container' => {
               'image' => 'datadog/ci',