Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-vendor psutil and wrapt (backport #7332 to 2.0) #7436

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

majorgreys
Copy link
Contributor

@majorgreys majorgreys commented Oct 31, 2023

Reverts #6651

Fixes #7316

Closes #7202

Co-authored-by: Zachary Groves [email protected]
Co-authored-by: Brett Langdon [email protected]
(cherry picked from commit 9f79fd5)

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance
    policy
  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Reverts #6651

Fixes #7316

Closes #7202

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
- [x] If this PR touches code that signs or publishes builds or
packages, or handles credentials of any kind, I've requested a review
from `@DataDog/security-design-and-guidance`.
- [x] This PR doesn't touch any of that.

---------

Co-authored-by: Zachary Groves <[email protected]>
Co-authored-by: Brett Langdon <[email protected]>
(cherry picked from commit 9f79fd5)
@majorgreys majorgreys enabled auto-merge (squash) October 31, 2023 18:38
emmettbutler
emmettbutler previously approved these changes Oct 31, 2023
@mabdinur mabdinur changed the title chore: re-vendor psutil and wrapt (#7332) chore: re-vendor psutil and wrapt (backport #7332 to 2.0) Nov 1, 2023
mabdinur
mabdinur previously approved these changes Nov 1, 2023
@mabdinur mabdinur closed this Nov 2, 2023
auto-merge was automatically disabled November 2, 2023 13:05

Pull request was closed

@mabdinur mabdinur reopened this Nov 2, 2023
@mabdinur mabdinur enabled auto-merge (squash) November 2, 2023 13:05
@mabdinur mabdinur dismissed stale reviews from emmettbutler and themself via 603ba07 November 2, 2023 13:50
@mabdinur mabdinur merged commit c76f642 into 2.0 Nov 2, 2023
45 checks passed
@mabdinur mabdinur deleted the backport-7332-to-2.0 branch November 2, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants