Skip to content

Parallelize benchmarks #13420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Parallelize benchmarks #13420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f1cf21
test new bp script
brettlangdon Apr 17, 2025
9d86f6e
Merge remote-tracking branch 'origin/main' into brettlangdon/benchmar…
brettlangdon May 14, 2025
1f31ec2
use registry.ddbuild.io image
brettlangdon May 14, 2025
f5f5b7e
update static commit sha
brettlangdon May 14, 2025
2ba36b2
install parallel
brettlangdon May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .gitlab/benchmarks/microbenchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ stages:
- report

variables:
BENCHMARKING_IMAGE_REGISTRY: 486234852809.dkr.ecr.us-east-1.amazonaws.com
BENCHMARKING_IMAGE_REGISTRY: registry.ddbuild.io
MICROBENCHMARKS_CI_IMAGE: $BENCHMARKING_IMAGE_REGISTRY/ci/benchmarking-platform:dd-trace-py
PACKAGE_IMAGE: registry.ddbuild.io/images/mirror/pypa/manylinux2014_x86_64:2024-08-12-7fde9b1
GITHUB_CLI_IMAGE: registry.ddbuild.io/github-cli:v27480869-eafb11d-2.43.0
BENCHMARKING_BRANCH: dd-trace-py
BENCHMARKING_BRANCH: brettlangdon/dd-trace-py.fix.parallel

.benchmarks:
stage: test
Expand All @@ -18,6 +18,8 @@ variables:
interruptible: true
timeout: 30m
dependencies: [ "baseline:build", "candidate" ]
before_script:
- apt-get update && apt-get install -y --no-install-recommends parallel
script: |
export REPORTS_DIR="$(pwd)/reports/" && (mkdir "${REPORTS_DIR}" || :)

Expand Down
4 changes: 3 additions & 1 deletion .gitlab/download-wheels-from-gh-actions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#!/bin/bash
set -eo pipefail

CI_COMMIT_SHA="1f31ec2949802373ddf8c378f82c87511d4e4d74"

if [ -z "$CI_COMMIT_SHA" ]; then
echo "Error: CI_COMMIT_SHA was not provided"
exit 1
Expand Down Expand Up @@ -42,7 +44,7 @@ if [[ $(gh run view $RUN_ID --exit-status --json status --jq .status) != "comple
echo "Waiting for workflow to finish"

# Give time to the job to finish
sleep 300 # 5 minutes
sleep 5 # 5 minutes

# wait for run to finish
gh run watch $RUN_ID --interval 60 --exit-status 1 --repo DataDog/dd-trace-py
Expand Down
Loading