Skip to content

chore(profiling): enable memalloc large heap test #13418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented May 14, 2025

This test is now runnable in CI after #13317

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim requested a review from a team as a code owner May 14, 2025 18:26
@taegyunkim taegyunkim added changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling labels May 14, 2025
@taegyunkim taegyunkim enabled auto-merge (squash) May 14, 2025 18:26
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/profiling_v2/collector/test_memalloc.py                           @DataDog/profiling-python

Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just tried this out earlier today and figured we should enable it. Looks like you beat me to it :) Runs in ~2 seconds on my macbook now.

Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 234 ± 4 ms.

The average import time from base is: 240 ± 4 ms.

The import time difference between this PR and base is: -6.0 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.520 ms (1.08%)
ddtrace.bootstrap.sitecustomize 1.750 ms (0.75%)
ddtrace.bootstrap.preload 1.750 ms (0.75%)
ddtrace.internal.remoteconfig.client 0.826 ms (0.35%)
ddtrace 0.770 ms (0.33%)
ddtrace._logger 0.084 ms (0.04%)
logging 0.084 ms (0.04%)
traceback 0.084 ms (0.04%)
contextlib 0.084 ms (0.04%)

@pr-commenter
Copy link

pr-commenter bot commented May 14, 2025

Benchmarks

Benchmark execution time: 2025-05-14 19:13:45

Comparing candidate commit 4cd60cb in PR branch taegyunkim/memalloc-large-heap-overhead with baseline commit ca14026 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 499 metrics, 4 unstable metrics.

scenario:iast_aspects-replace_aspect

  • 🟥 execution_time [+641.347ns; +739.724ns] or [+14.120%; +16.286%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants