Skip to content

Revert "chore(ci_visibility): move retry logic to pytest_runtest_protocol (#13376)" #13416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vitor-de-araujo
Copy link
Contributor

@vitor-de-araujo vitor-de-araujo commented May 14, 2025

This reverts commit 355694d.

This change caused some errors with unittest (which did not run when the original PR was merged).

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@vitor-de-araujo vitor-de-araujo requested a review from a team as a code owner May 14, 2025 15:17
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/contrib/internal/pytest/_atr_utils.py                           @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/_attempt_to_fix.py                      @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/_efd_utils.py                           @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/_plugin_v2.py                           @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/_retry_utils.py                         @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/_utils.py                               @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/plugin.py                               @DataDog/ci-app-libraries

@vitor-de-araujo vitor-de-araujo added changelog/no-changelog A changelog entry is not required for this PR. CI App labels May 14, 2025
@vitor-de-araujo vitor-de-araujo enabled auto-merge (squash) May 14, 2025 15:21
Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 234 ± 3 ms.

The average import time from base is: 238 ± 4 ms.

The import time difference between this PR and base is: -3.7 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.174 ms (0.93%)
ddtrace.bootstrap.sitecustomize 1.496 ms (0.64%)
ddtrace.bootstrap.preload 1.496 ms (0.64%)
ddtrace.internal.remoteconfig.client 0.727 ms (0.31%)
ddtrace 0.678 ms (0.29%)

@pr-commenter
Copy link

pr-commenter bot commented May 14, 2025

Benchmarks

Benchmark execution time: 2025-05-14 16:02:04

Comparing candidate commit a0619e2 in PR branch vitor-de-araujo/SDTEST-1850/refactor-retry-logic-2-revert with baseline commit 355694d in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 502 metrics, 5 unstable metrics.

scenario:iast_aspects-replace_aspect

  • 🟥 execution_time [+641.381ns; +748.623ns] or [+14.105%; +16.463%]

@vitor-de-araujo vitor-de-araujo merged commit ecc84b1 into main May 15, 2025
798 of 802 checks passed
@vitor-de-araujo vitor-de-araujo deleted the vitor-de-araujo/SDTEST-1850/refactor-retry-logic-2-revert branch May 15, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants