Skip to content

chore(ci): move the pygoat CI step from hatch to riot #13395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented May 13, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@juanjux juanjux self-assigned this May 13, 2025
@juanjux juanjux requested review from a team as code owners May 13, 2025 08:30
@juanjux juanjux added the changelog/no-changelog A changelog entry is not required for this PR. label May 13, 2025
@juanjux juanjux requested review from a team as code owners May 13, 2025 08:30
@juanjux juanjux added the ASM Application Security Monitoring label May 13, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

.riot/requirements/115ddbf.txt                                          @DataDog/apm-python
.riot/requirements/a19438c.txt                                          @DataDog/apm-python
.riot/requirements/d74f3e1.txt                                          @DataDog/apm-python
hatch.toml                                                              @DataDog/python-guild
lib-injection/sources/min_compatible_versions.csv                       @DataDog/apm-core-python
min_compatible_versions.csv                                             @DataDog/apm-core-python
riotfile.py                                                             @DataDog/apm-python
tests/appsec/suitespec.yml                                              @DataDog/asm-python

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies


Was this helpful? Give us feedback!

@juanjux juanjux changed the title move the pygoat CI step from hatch to riot chore(ci): move the pygoat CI step from hatch to riot May 13, 2025
Copy link
Contributor

github-actions bot commented May 13, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 233 ± 2 ms.

The average import time from base is: 236 ± 3 ms.

The import time difference between this PR and base is: -3.2 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.119 ms (0.91%)
ddtrace.bootstrap.sitecustomize 1.442 ms (0.62%)
ddtrace.bootstrap.preload 1.442 ms (0.62%)
ddtrace.internal.remoteconfig.client 0.701 ms (0.30%)
ddtrace 0.678 ms (0.29%)

Signed-off-by: Juanjo Alvarez <[email protected]>
@pr-commenter
Copy link

pr-commenter bot commented May 13, 2025

Benchmarks

Benchmark execution time: 2025-05-16 13:02:27

Comparing candidate commit 5c29f84 in PR branch juanjux/iast-integrations-pygoat-to-riot with baseline commit f5f1cd0 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 526 metrics, 8 unstable metrics.

scenario:iast_aspects-format_map_aspect

  • 🟥 execution_time [+266.472ns; +386.080ns] or [+8.290%; +12.012%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟥 execution_time [+921.785ns; +1000.213ns] or [+19.063%; +20.685%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring backport 2.21 changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants