-
Notifications
You must be signed in to change notification settings - Fork 437
chore(benchmarks): combine ddtrace-run and startup benchmarks #13391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 232 ± 2 ms. The average import time from base is: 237 ± 4 ms. The import time difference between this PR and base is: -4.6 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies ❌ Pipelines Next StepsThe following jobs failed due to code errors: System Tests / system-tests (django-py3.13, other)1 failed test. AssertionError: Invalid IAST data for span: {'sources': [{'origin': 'http.request.parameter', 'name': 'url', 'redacted': True, 'pattern': 'abcdefghijklmnopqrstuvwxyzABCDE'}], 'vulnerabilities': [{'type': 'SSRF', 'evidence': {'valueParts': [{'source': 0, 'value': 'http://weblog:7777/?token='}, {'redacted': True, 'source': 0, 'pattern': 'ABCDE'}]}, 'location': {'spanId': 2256514972871161777, 'path': 'app/urls.py', 'line': 712, 'method': 'make_distant_call', 'class': ''}, 'hash': 1795483706, 'stackId': '1'}]} System Tests / system-tests (fastapi, other)1 failed test. Assertion Error: Invalid IAST data for span: {'sources': [{'origin': 'http.request.parameter', 'name': 'url', 'redacted': True, 'pattern': 'abcdefghijklmnopqrstuvwxyzABCDE'}], 'vulnerabilities': [{'type': 'SSRF', 'evidence': {'valueParts': [{'source': 0, 'value': 'http://weblog:7777/?token='}, {'redacted': True, 'source': 0, 'pattern': 'ABCDE'}]}, 'location': {'spanId': 3295642735528587381, 'path': 'main.py', 'line': 368, 'method': 'make_distant_call', 'class': ''}, 'hash': 2261779420, 'stackId': '1'}]} System Tests / system-tests (uwsgi-poc, other)1 failed test. AssertionError: Invalid IAST data for span: {'sources': [{'origin': 'http.request.parameter', 'name': 'url', 'redacted': True, 'pattern': 'abcdefghijklmnopqrstuvwxyzABCDE'}], 'vulnerabilities': [{'type': 'SSRF', 'evidence': {'valueParts': [{'source': 0, 'value': 'http://weblog:7777/?token='}, {'redacted': True, 'source': 0, 'pattern': 'ABCDE'}]}, 'location': {'spanId': 11476412351368578441, 'path': 'app.py', 'line': 518, 'method': 'make_distant_call', 'class': ''}, 'hash': 3581058908, 'stackId': '1'}]} The following jobs failed due to platform errors: Require Checklist / require-checklistIncomplete task checklist: PR author and reviewer criteria not completed as per requirements. Was this helpful? Give us feedback! |
BenchmarksBenchmark execution time: 2025-05-12 18:11:31 Comparing candidate commit 4c9f7dd in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 388 metrics, 5 unstable metrics. scenario:iast_aspects-ospathdirname_aspect
|
ddtrace-run benchmarks are broken, this PR removes this benchmarking scenario and combines it with the new
startup
scenario.Issues with ddtrace-run benchmarks:
_DD_INSTRUMENTATION_TELEMETRY_TESTS_FORCE_APP_STARTED
must be set to true. Otherwise telemetry events will be recorded 10 seconds after ddtrace instrumentation is appliedChecklist
Reviewer Checklist