Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test optimization] Add support for Drone CI #5304

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Mariovido
Copy link
Contributor

What does this PR do?

This PR is intended to add support for Drone CI.

Motivation

We want to increase our support in the main stream CI providers.

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Feb 20, 2025

Overall package size

Self size: 8.77 MB
Deduped: 94.97 MB
No deduping: 95.48 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.94%. Comparing base (96bb84a) to head (ed95ab0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5304   +/-   ##
=======================================
  Coverage   80.94%   80.94%           
=======================================
  Files         488      488           
  Lines       21844    21847    +3     
=======================================
+ Hits        17681    17684    +3     
  Misses       4163     4163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 20, 2025

Datadog Report

Branch report: mario.vidal/add_support_drone_ci
Commit report: 91b2ff5
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 664 Passed, 0 Skipped, 13m 47.68s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 20, 2025

Benchmarks

Benchmark execution time: 2025-02-21 14:10:45

Comparing candidate commit d01b36d in PR branch mario.vidal/add_support_drone_ci with baseline commit 96bb84a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 920 metrics, 13 unstable metrics.

[CI_JOB_NAME]: DRONE_STEP_NAME,
[CI_STAGE_NAME]: DRONE_STAGE_NAME,
[CI_WORKSPACE_PATH]: DRONE_WORKSPACE,
[CI_ENV_VARS]: JSON.stringify({ }), // MISSING
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to add this if we have nothing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed :)

[CI_PIPELINE_NAME]: DRONE_REPO_NAME,
[CI_PIPELINE_NUMBER]: DRONE_BUILD_NUMBER,
[CI_PIPELINE_URL]: DRONE_BUILD_LINK,
[CI_JOB_URL]: 'XXX', // MISSING
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a pity we don't have this, but it's OK, we can leave it empty

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Comment on lines 664 to 666
[GIT_COMMIT_AUTHOR_DATE]: 'XXX', // MISSING
[GIT_COMMIT_COMMITTER_NAME]: 'XXX', // MISSING
[GIT_COMMIT_COMMITTER_EMAIL]: 'XXX', // MISSING
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can leave this empty too. These tags specifically will be filled by our git commands

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

tags = {
[CI_PROVIDER_NAME]: 'drone',
[CI_PIPELINE_ID]: DRONE_BUILD_NUMBER,
[CI_PIPELINE_NAME]: DRONE_REPO_NAME,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the pipeline_id and pipeline_name

@Mariovido Mariovido marked this pull request as ready for review February 21, 2025 14:03
@Mariovido Mariovido requested review from a team as code owners February 21, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants