more correct package guardrails (#4600)

While _functioning_ correctly, the logging and telemetry was broken for packages that met one range, but didn't meet a subsequent range. This is now fixed.
DataDog · Aug 13, 2024 · e970623 · e970623
1 parent 683df27
commit e970623
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/integration-tests/package-guardrails.spec.js b/integration-tests/package-guardrails.spec.js
@@ -64,7 +64,9 @@ false
     })
     context('when fastify is latest and logging enabled', () => {
       useSandbox(['fastify'])
-      it('should instrument the package', () => runTest('true\n'))
+      useEnv({ DD_TRACE_DEBUG })
+      it('should instrument the package', () =>
+        runTest('Application instrumentation bootstrapping complete\ntrue\n'))
     })
   })
 

diff --git a/packages/datadog-instrumentations/src/helpers/register.js b/packages/datadog-instrumentations/src/helpers/register.js
@@ -98,7 +98,7 @@ for (const packageName of names) {
           log.error(e)
           continue
         }
-        if (!Object.hasOwnProperty(namesAndSuccesses, name)) {
+        if (typeof namesAndSuccesses[`${name}@${version}`] === 'undefined') {
           namesAndSuccesses[`${name}@${version}`] = false
         }