Support processors and scanners updates for API Sec via RC (#3981)

DataDog · Jan 30, 2024 · 32ea712 · 32ea712
1 parent 7c3157e
commit 32ea712
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 2 deletions.
diff --git a/packages/dd-trace/src/appsec/rule_manager.js b/packages/dd-trace/src/appsec/rule_manager.js
@@ -69,9 +69,9 @@ function updateWafFromRC ({ toUnapply, toApply, toModify }) {
         item.apply_error = 'Multiple ruleset received in ASM_DD'
       } else {
         if (file && file.rules && file.rules.length) {
-          const { version, metadata, rules } = file
+          const { version, metadata, rules, processors, scanners } = file
 
-          newRuleset = { version, metadata, rules }
+          newRuleset = { version, metadata, rules, processors, scanners }
           newRulesetId = id
         }
 

diff --git a/packages/dd-trace/test/appsec/rule_manager.spec.js b/packages/dd-trace/test/appsec/rule_manager.spec.js
@@ -300,6 +300,33 @@ describe('AppSec Rule Manager', () => {
               'confidence': '1'
             },
             'conditions': []
+          }],
+          processors: [{
+            id: 'test-processor-id',
+            generator: 'test-generator',
+            evaluate: false,
+            output: true
+          }],
+          scanners: [{
+            id: 'test-scanner-id',
+            name: 'Test name',
+            key: {
+              operator: 'match_regex',
+              parameters: {
+                regex: 'test-regex'
+              }
+            },
+            value: {
+              operator: 'match_regex',
+              parameters: {
+                regex: 'test-regex-2'
+              }
+            },
+            tags: {
+              type: 'card',
+              card_type: 'test',
+              category: 'payment'
+            }
           }]
         }
 
@@ -333,6 +360,33 @@ describe('AppSec Rule Manager', () => {
               'confidence': '1'
             },
             'conditions': []
+          }],
+          processors: [{
+            id: 'test-processor-id',
+            generator: 'test-generator',
+            evaluate: false,
+            output: true
+          }],
+          scanners: [{
+            id: 'test-scanner-id',
+            name: 'Test name',
+            key: {
+              operator: 'match_regex',
+              parameters: {
+                regex: 'test-regex'
+              }
+            },
+            value: {
+              operator: 'match_regex',
+              parameters: {
+                regex: 'test-regex-2'
+              }
+            },
+            tags: {
+              type: 'card',
+              card_type: 'test',
+              category: 'payment'
+            }
           }]
         }