Skip to content

Commit

Permalink
Prioritize auth configuration values over environment variables (#1787)
Browse files Browse the repository at this point in the history
Setting `DD_API_KEY` and `DD_APP_KEY` in the environment should not override values
manually passed to the configuration init.

Closes #1786
  • Loading branch information
therve authored Jan 5, 2024
1 parent d58f88a commit c84ad6d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .generator/src/generator/templates/configuration.j2
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,9 @@ class Configuration:
# Load default values from environment
if "DD_SITE" in os.environ:
self.server_variables["site"] = os.environ["DD_SITE"]
if "DD_API_KEY" in os.environ:
if "DD_API_KEY" in os.environ and not self.api_key.get("apiKeyAuth"):
self.api_key["apiKeyAuth"] = os.environ["DD_API_KEY"]
if "DD_APP_KEY" in os.environ:
if "DD_APP_KEY" in os.environ and not self.api_key.get("appKeyAuth"):
self.api_key["appKeyAuth"] = os.environ["DD_APP_KEY"]

def __deepcopy__(self, memo):
Expand Down
4 changes: 2 additions & 2 deletions src/datadog_api_client/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -284,9 +284,9 @@ def __init__(
# Load default values from environment
if "DD_SITE" in os.environ:
self.server_variables["site"] = os.environ["DD_SITE"]
if "DD_API_KEY" in os.environ:
if "DD_API_KEY" in os.environ and not self.api_key.get("apiKeyAuth"):
self.api_key["apiKeyAuth"] = os.environ["DD_API_KEY"]
if "DD_APP_KEY" in os.environ:
if "DD_APP_KEY" in os.environ and not self.api_key.get("appKeyAuth"):
self.api_key["appKeyAuth"] = os.environ["DD_APP_KEY"]

def __deepcopy__(self, memo):
Expand Down

0 comments on commit c84ad6d

Please sign in to comment.