Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ƒeat: add readiness + liveness #945

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ƒeat: add readiness + liveness #945

wants to merge 1 commit into from
+44 −7

Conversation

aymericDD
Copy link
Contributor

@aymericDD aymericDD commented Dec 20, 2024 •
edited
Loading

What does this PR do?

  • Adds new functionality
  • Alters existing functionality
  • Fixes a bug
  • Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

  • Add a liveness and a readiness to the manager to ensure the webhooks are up and running before considering the pod ready.

The liveness and the readiness return a 200 HTTP OK Status code if the webhooks are ready to serve requests.

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • locally.
    • as a canary deployment to a cluster.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 20, 2024 •
edited
Loading

Datadog Report

Branch report: feat/add-liveness-readiness
Commit report: 3873ba6
Test service: chaos-controller

✅ 0 Failed, 983 Passed, 8 Skipped, 18m 59.72s Total Time

@aymericDD aymericDD force-pushed the feat/add-liveness-readiness branch 2 times, most recently from 4527fad to 92b08c6 Compare December 20, 2024 14:54
@aymericDD
ƒeat: add readiness + liveness
3873ba6 
Add a liveness and a readiness to the manager to ensure the webhooks are up and running before considering the pod ready.

Jira: CHAOSPLT-560
@aymericDD aymericDD force-pushed the feat/add-liveness-readiness branch from 92b08c6 to 3873ba6 Compare December 20, 2024 15:07
@aymericDD aymericDD marked this pull request as ready for review January 2, 2025 08:11
@aymericDD aymericDD requested a review from a team as a code owner January 2, 2025 08:11
ptnapoleon
ptnapoleon reviewed Jan 2, 2025
View reviewed changes
examples/disruption_crons/network_drop.yaml
@@ -18,4 +18,4 @@ spec:
count: 1
network:
drop: 100 # percentage of outgoing packets to drop
duration: 10s # disruption will time out after 10 seconds
duration: 10s # disruption will time out after 10 seconds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
duration: 10s # disruption will time out after 10 seconds
duration: 10s # disruption will time out after 10 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptnapoleon ptnapoleon ptnapoleon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymericDD @ptnapoleon