Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.5.0 #130

Merged
merged 44 commits into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
15a717a
Fix create-plugin templates
yoannmoinet Nov 28, 2024
39fe408
Move sourcemaps into error-tracking instead of rum
yoannmoinet Nov 29, 2024
e15aca1
Simplify the test script
yoannmoinet Nov 29, 2024
14d2999
Update doc and types
yoannmoinet Nov 29, 2024
38e3771
Factorise esbuild entries helper
yoannmoinet Jan 14, 2025
95b68e3
Fix cwd issue with working dir cwd in rollup/vite
yoannmoinet Jan 14, 2025
ac097a7
Detect and flag duplicate plugins
yoannmoinet Jan 14, 2025
8326fb2
Refactor injection plugin to include positions
yoannmoinet Jan 14, 2025
4568662
Remove injected file from xspack reports
yoannmoinet Jan 14, 2025
7655ccc
Comments, TODOs and missing deps
yoannmoinet Jan 14, 2025
ea1d927
Inconsequential config updates and bumps
yoannmoinet Jan 14, 2025
902c953
More reliable environment setup for Jest running context
yoannmoinet Jan 14, 2025
9121e5a
Sandbox fixture projects and builds in a temp working directory
yoannmoinet Jan 14, 2025
2c015cb
Bump node to 18.20.5
yoannmoinet Jan 14, 2025
ce25b2b
Lock update
yoannmoinet Jan 14, 2025
93bd559
Fix readme template RX to handle double markers
yoannmoinet Jan 16, 2025
acb3bef
Lighten and improve readmes
yoannmoinet Jan 16, 2025
eac67e1
Post review update
yoannmoinet Jan 17, 2025
1e302a3
Post review update
yoannmoinet Jan 17, 2025
a2995f7
Use volta's version of node
yoannmoinet Feb 6, 2025
b41de1c
Better naming for matrix
yoannmoinet Feb 6, 2025
385f76f
Update naming
yoannmoinet Feb 6, 2025
b5d12b0
Add auth to doRequest helper
yoannmoinet Jan 15, 2025
5413e17
Improve logger and build report with infos on the bundler
yoannmoinet Jan 15, 2025
e18b1d2
Fix injection plugin with better isolation
yoannmoinet Jan 15, 2025
a9c86d4
Change bundling to allow plugins to add their own files to build
yoannmoinet Jan 15, 2025
30c18b1
Small test inconsequential update
yoannmoinet Jan 16, 2025
f6816d5
Empty commit to re-trigger CI
yoannmoinet Feb 11, 2025
d9c4634
Move unit tests in their own folder
yoannmoinet Feb 7, 2025
cf30c24
Add devserver CLI
yoannmoinet Feb 7, 2025
5783b4d
Update bundling
yoannmoinet Feb 7, 2025
c03abdd
Organize and factorize helpers
yoannmoinet Feb 7, 2025
ad17211
Install playwright
yoannmoinet Feb 7, 2025
b6b9f07
Configure playwright
yoannmoinet Feb 7, 2025
12f2d61
Update CI to run e2e tests
yoannmoinet Feb 7, 2025
684d289
Re-enforce rspack potential race condition on injected file
yoannmoinet Feb 7, 2025
7df0435
Documentation update for testing
yoannmoinet Feb 7, 2025
d3f47cb
Add a smoke test
yoannmoinet Feb 10, 2025
5ef1502
Remove `@dd/rum-plugin` dependency
yoannmoinet Feb 11, 2025
551a20f
Remove streaming of file for stronger templating
yoannmoinet Feb 13, 2025
7eb33b3
Rename test
yoannmoinet Feb 13, 2025
c5f7bcf
Revert breaking change on types bundling
yoannmoinet Feb 13, 2025
73662a4
Update CI
yoannmoinet Feb 13, 2025
604e477
v2.5.0
yoannmoinet Feb 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ module.exports = {
],
'no-delete-var': 'error',
'no-label-var': 'error',
'no-shadow': 'error',
'no-shadow': 'off',
'@typescript-eslint/no-shadow': ['error'],
'no-shadow-restricted-names': 'error',
'no-undef': 'error',
'no-undef-init': 'error',
Expand Down
6 changes: 3 additions & 3 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ packages/tests/src/plugins/injection @yoannmoin
packages/plugins/telemetry @DataDog/frontend-devx @yoannmoinet
packages/tests/src/plugins/telemetry @DataDog/frontend-devx @yoannmoinet

# Rum
packages/plugins/rum @DataDog/rum @yoannmoinet
packages/tests/src/plugins/rum @DataDog/rum @yoannmoinet
# Error Tracking
packages/plugins/error-tracking @yoannmoinet
packages/tests/src/plugins/error-tracking @yoannmoinet
108 changes: 99 additions & 9 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,33 +8,123 @@ jobs:
fail-fast: false
matrix:
node:
- 18
- 20
- node-version-file: 'package.json'
- node-version: 20.x

name: Unit tests w/ Node.js ${{matrix.node}}.x
name: Unit tests w/ Node.js ${{matrix.node.node-version || matrix.node.node-version-file}}
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Install Node ${{matrix.node}}.x

- name: Install Node ${{matrix.node.node-version || matrix.node.node-version-file}}
uses: actions/setup-node@v4
with: ${{matrix.node}}

- name: Cache build:all
id: cache-build
uses: actions/cache@v4
with:
node-version: ${{matrix.node}}.x
path: packages/published/**/dist
key: ${{ matrix.node }}-cache-build-${{ hashFiles('packages/published/**', 'yarn.lock') }}

- run: yarn install
- run: yarn test

- name: Build all plugins
if: steps.cache-build.outputs.cache-hit != 'true'
run: yarn build:all

- run: yarn test:unit

e2e:
timeout-minutes: 10

name: End to End
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

- name: Install Node
uses: actions/setup-node@v4
with:
node-version-file: 'package.json'

- name: Cache build:all
id: cache-build
uses: actions/cache@v4
with:
path: packages/published/**/dist
key: node18-cache-build-${{ hashFiles('packages/published/**', 'yarn.lock') }}

- name: Cache playwright binaries
id: cache-playwright-binaries
uses: actions/cache@v4
with:
path: |
~/.cache/ms-playwright
~/Library/Caches/ms-playwright
%USERPROFILE%\AppData\Local\ms-playwright
key: cache-playwright-binaries-${{ hashFiles('yarn.lock') }}

- run: yarn install

- name: Install playwright
run: yarn workspace @dd/tests playwright install --with-deps

- name: Build all plugins
if: steps.cache-build.outputs.cache-hit != 'true'
run: yarn build:all

- run: yarn test:e2e

- name: Save playwright cache
if: always() && steps.cache-playwright-binaries.outputs.cache-hit != 'true'
id: save-playwright-cache
uses: actions/cache/save@v4
with:
path: |
~/.cache/ms-playwright
~/Library/Caches/ms-playwright
%USERPROFILE%\AppData\Local\ms-playwright
key: cache-playwright-binaries-${{ hashFiles('yarn.lock') }}

- uses: actions/upload-artifact@v4
if: ${{ !cancelled() && failure() }}
with:
name: playwright
path: |
packages/tests/playwright-report
packages/tests/test-results
retention-days: 3

lint:
name: Linting
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Install node

- name: Install Node
uses: actions/setup-node@v4
with:
node-version: '18.19.0'
node-version-file: 'package.json'

- name: Cache build:all
id: cache-build
uses: actions/cache@v4
with:
path: packages/published/**/dist
key: node18-cache-build-${{ hashFiles('packages/published/**', 'yarn.lock') }}

- run: yarn install
- run: yarn build:all

- name: Build all plugins
if: steps.cache-build.outputs.cache-hit != 'true'
run: yarn build:all

- run: yarn typecheck:all

- run: yarn cli integrity

- run: git diff --exit-code && git diff --cached --exit-code || (echo "Please run 'yarn cli integrity' and commit the result." && exit 1)
1 change: 0 additions & 1 deletion .node-version

This file was deleted.

3 changes: 2 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,6 @@
"**/.yarn/": true,
"**/.yarnrc.yml": true,
"**/yarn.lock": true
}
},
"typescript.tsdk": "node_modules/typescript/lib"
}
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file added .yarn/cache/fsevents-patch-19706e7e35-10.zip
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
11 changes: 11 additions & 0 deletions LICENSES-3rdparty.csv
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,13 @@ Component,Origin,Licence,Copyright
@nodelib/fs.walk,npm,MIT,(https://www.npmjs.com/package/@nodelib/fs.walk)
@pkgjs/parseargs,npm,MIT,(https://github.com/pkgjs/parseargs#readme)
@pkgr/core,npm,MIT,JounQin (https://github.com/un-ts/pkgr/blob/master/packages/core)
@playwright/test,npm,Apache-2.0,Microsoft Corporation (https://playwright.dev)
@rollup/plugin-babel,virtual,MIT,Rich Harris (https://github.com/rollup/plugins/tree/master/packages/babel#readme)
@rollup/plugin-commonjs,virtual,MIT,Rich Harris (https://github.com/rollup/plugins/tree/master/packages/commonjs/#readme)
@rollup/plugin-esm-shim,virtual,MIT,Peter Placzek (https://github.com/rollup/plugins/tree/master/packages/esm-shim#readme)
@rollup/plugin-json,virtual,MIT,rollup (https://github.com/rollup/plugins/tree/master/packages/json#readme)
@rollup/plugin-node-resolve,virtual,MIT,Rich Harris (https://github.com/rollup/plugins/tree/master/packages/node-resolve/#readme)
@rollup/plugin-terser,virtual,MIT,Peter Placzek (https://github.com/rollup/plugins/tree/master/packages/terser#readme)
@rollup/pluginutils,virtual,MIT,Rich Harris (https://github.com/rollup/plugins/tree/master/packages/pluginutils#readme)
@rollup/rollup-darwin-arm64,npm,MIT,Lukas Taegert-Atkinson (https://rollupjs.org/)
@rspack/binding,npm,MIT,(https://rspack.dev)
Expand Down Expand Up @@ -205,6 +208,8 @@ Component,Origin,Licence,Copyright
@types/jest,npm,MIT,(https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/jest)
@types/json-schema,npm,MIT,(https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/json-schema)
@types/json5,npm,MIT,Jason Swearingen (https://www.npmjs.com/package/@types/json5)
@types/lodash,npm,MIT,(https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/lodash)
@types/lodash.template,npm,MIT,(https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/lodash.template)
@types/minimatch,npm,MIT,(https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/minimatch)
@types/mute-stream,npm,MIT,(https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/mute-stream)
@types/node,npm,MIT,(https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node)
Expand Down Expand Up @@ -640,9 +645,12 @@ listr2,npm,MIT,Cenk Kilic (https://srcs.kilic.dev)
loader-runner,npm,MIT,Tobias Koppers @sokra (https://github.com/webpack/loader-runner#readme)
loader-utils,npm,MIT,Tobias Koppers @sokra (https://www.npmjs.com/package/loader-utils)
locate-path,npm,MIT,Sindre Sorhus (sindresorhus.com)
lodash._reinterpolate,npm,MIT,John-David Dalton (https://lodash.com/)
lodash.debounce,npm,MIT,John-David Dalton (https://lodash.com/)
lodash.memoize,npm,MIT,John-David Dalton (https://lodash.com/)
lodash.merge,npm,MIT,John-David Dalton (https://lodash.com/)
lodash.template,npm,MIT,John-David Dalton (https://lodash.com/)
lodash.templatesettings,npm,MIT,John-David Dalton (https://lodash.com/)
log-symbols,npm,MIT,Sindre Sorhus (sindresorhus.com)
log-update,npm,MIT,Sindre Sorhus (sindresorhus.com)
lru-cache,npm,ISC,Isaac Z. Schlueter (https://www.npmjs.com/package/lru-cache)
Expand Down Expand Up @@ -739,6 +747,8 @@ picomatch,npm,MIT,Jon Schlinkert (https://github.com/micromatch/picomatch)
pify,npm,MIT,Sindre Sorhus (sindresorhus.com)
pirates,npm,MIT,Ari Porad (https://github.com/danez/pirates#readme)
pkg-dir,npm,MIT,Sindre Sorhus (sindresorhus.com)
playwright,npm,Apache-2.0,Microsoft Corporation (https://playwright.dev)
playwright-core,npm,Apache-2.0,Microsoft Corporation (https://playwright.dev)
please-upgrade-node,npm,MIT,typicode (https://github.com/typicode/please-upgrade-node#readme)
posix-character-classes,npm,MIT,Jon Schlinkert (https://github.com/jonschlinkert/posix-character-classes)
possible-typed-array-names,npm,MIT,Jordan Harband (https://github.com/ljharb/possible-typed-array-names#readme)
Expand Down Expand Up @@ -822,6 +832,7 @@ simple-git,npm,MIT,Steve King (https://www.npmjs.com/package/simple-git)
sisteransi,npm,MIT,Terkel Gjervig (https://terkel.com)
slash,npm,MIT,Sindre Sorhus (sindresorhus.com)
slice-ansi,npm,MIT,(https://www.npmjs.com/package/slice-ansi)
smob,npm,MIT,Peter Placzek (https://github.com/Tada5hi/smob#readme)
snapdragon,npm,MIT,Jon Schlinkert (https://github.com/jonschlinkert/snapdragon)
snapdragon-node,npm,MIT,Jon Schlinkert (https://github.com/jonschlinkert/snapdragon-node)
snapdragon-util,npm,MIT,Jon Schlinkert (https://github.com/jonschlinkert/snapdragon-util)
Expand Down
Loading