[test] Add e2e testing #125
Conversation
yoannmoinet
changed the base branch from
yoann/inject-browser-sdk
to
yoann/v2.5.0
yoannmoinet
force-pushed
the
yoann/add-e2e-testing
branch
2 times, most recently
from
83fa727 to
0c40188
Compare
yoannmoinet
force-pushed
the
yoann/add-e2e-testing
branch
from
0c40188 to
a9be777
Compare
yoannmoinet
changed the base branch from
yoann/v2.5.0
to
yoann/miscelaneous-updates
yoannmoinet
requested review from
jakub-g,
elbywan and
Ayc0
and removed request for
a team and
jakub-g
| - run: yarn install | ||
|
|
||
| - name: Install playwright | ||
| run: yarn workspace @dd/tests playwright install --with-deps |
There was a problem hiding this comment.
I believe that this step will still run even when the playwright cache is hit
There was a problem hiding this comment.
Yes, it is necessary, we can only cache the binaries, but we still need to install some shared libraries (installed in a different directory than the binaries).
Though, it will not need to download the binaries (browsers mostly).
| // Transform the content here with the context we have. | ||
| callback( | ||
| null, | ||
| template(chunk.toString('utf-8'), { interpolate: INTERPOLATE_RX })(context), |
There was a problem hiding this comment.
I'm wondering if this could fail when a particular chunk includes the start symbol ({{) but not the other one (}}), which would in this case be included in the next chunk?
There was a problem hiding this comment.
That's a fair concern, I'll see if I can prevent this issue from happening.
There was a problem hiding this comment.
Removed the streaming process, and used fs.readFile instead.
Didn't find any solution to keep the streaming.
| await page.waitForSelector('body'); | ||
| }; | ||
|
|
||
| describe('Browser SDK injection', () => { |
There was a problem hiding this comment.
Browser SDK injection
I think this is an oversight, the description seems to be off
What and why?
It would feel safer to actually test in browser, IRL situations.
How?
Add e2e testing with Playwright.
unit/and add thee2e/peer directory.yarn cli dev-servercommand to run a local dev server.yarn test:unit.yarn test:e2ecommand to run playwright.