Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: core api controllers #21

Merged
merged 8 commits into from
Sep 13, 2024
Merged

bugfix: core api controllers #21

merged 8 commits into from
Sep 13, 2024

Conversation

kkiani
Copy link
Contributor

@kkiani kkiani commented Sep 12, 2024 •
edited
Loading

Description

This PR is targeting multiple bugs with Damavand's core APIs:

  • Sparkle locked to a bugfix branch instead of a version.
  • Factory controller does not pass the region to controllers.
  • Provisioning of the resources is happening before creation of the applications, leading to miss configuration of resources layer.
  • Using id in controllers interfaces causing confusion.

@kkiani kkiani requested a review from callarelli93 September 13, 2024 07:51
@kkiani kkiani changed the base branch from main to feature/spark September 13, 2024 07:56
@kkiani kkiani merged commit 1504d60 into feature/spark Sep 13, 2024
0 of 2 checks passed
@kkiani kkiani deleted the bugfix/core-api-controllers branch September 13, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callarelli93 callarelli93 callarelli93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkiani @callarelli93