DT-1199: Increase azure signed url TTL to 1 hour #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snf2ye
requested review from
pshapiro4broad and
fboulnois
and removed request for
a team
|
pshapiro4broad
approved these changes
Feb 11, 2025
fboulnois
approved these changes
Feb 12, 2025
| @@ -99,7 +99,7 @@ public class DrsService { | |||
| private static final String ACCESS_ID_SEPARATOR = "*"; | |||
| private static final String DRS_OBJECT_VERSION = "0"; | |||
| @VisibleForTesting static final Duration URL_TTL = Duration.ofMinutes(15); | |||
|
|
|||
| static final Duration AZURE_URL_TTL = Duration.ofMinutes(60); | |||
There was a problem hiding this comment.
Minor suggestion: should we pull this out into an environment variable that can be changed? It may not be worth the effort.
There was a problem hiding this comment.
Good idea - but, given this is for Azure, I don't think it is worth the effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/DT-1199
Addresses
The customer delivery team is running into timeout issues when downloading larger files via Azure signed urls. The current TTL (time to live) for the urls is 15 minutes. I think we can reasonably extend this to 1 hour (we already do this for snapshot export manifests). This will not solve all use cases, but we think it will get them most of the way.
Summary of changes
Testing Strategy